-
Notifications
You must be signed in to change notification settings - Fork 713
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix OurViewChange small race (#5356)
Always queue OurViewChange event before we send view changes to our peers, because otherwise we risk the peers sending us a message that can be processed by our subsystems before OurViewChange. Normally, this is not really a problem because the latency of the ViewChange we send to our peers is way higher that our subsystem processing OurViewChange, however on testnets like versi where CPU is sometimes overcommitted this race gets triggered occasionally, so let's fix it by sending the messages in the right order. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
- Loading branch information
Showing
2 changed files
with
33 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
||
title: Fix OurViewChange small race | ||
|
||
doc: | ||
- audience: Node Dev | ||
description: | | ||
Always queue OurViewChange event before we send view changes to our peers, because otherwise we risk | ||
the peers sending us a message that can be processed by our subsystems before OurViewChange. | ||
Normally, this is not really a problem because the latency of the ViewChange we send to our peers | ||
is way higher than that of our subsystem processing OurViewChange, however on testnets like versi | ||
where CPUs are sometimes overcommitted this race gets triggered occasionally, so let's fix it by | ||
sending the messages in the right order. | ||
|
||
crates: | ||
- name: polkadot-network-bridge | ||
bump: minor |