-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parity-publish #6549
Update parity-publish #6549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for handling this 🙏
Just some minor nits around nightly version bump and jsonrpsee downgrade.
I think I can close #6535 now since you also update metadata here, thanks
All GitHub workflows were cancelled due to failure one of the required jobs. |
The semver check is taking a really long time due to all the Cargo.toml changes and the new parity publish now checks those. This can probably be circumvented by having parity publish not bothering to compile the crates if no source changes and no dep changes. For now it shouldn't come up much. |
Would love to include this to origin/master to unblock semver-checks for: What are the next steps to merge this? 🙏 |
There were still come issues with parity-publish .10.1. .10.2 is now released so merging as soon as approved. |
homepage.workspace = true | ||
repository.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Morganamilo why just these two bridges modules? Other bridges modules also miss this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the others aren't published? The changes were generated using the crates parity-publish check complained about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job here! Thanks again for handling this 🙏
No description provided.