Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parity-publish #6549

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Update parity-publish #6549

merged 10 commits into from
Dec 3, 2024

Conversation

Morganamilo
Copy link
Contributor

No description provided.

@Morganamilo Morganamilo requested review from a team as code owners November 20, 2024 09:21
@Morganamilo Morganamilo added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels Nov 20, 2024
@Morganamilo Morganamilo requested a review from a team as a code owner November 20, 2024 09:43
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 20, 2024 09:44
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for handling this 🙏

Just some minor nits around nightly version bump and jsonrpsee downgrade.

I think I can close #6535 now since you also update metadata here, thanks

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/11930738489
Failed job name: build-rustdoc

@Morganamilo
Copy link
Contributor Author

The semver check is taking a really long time due to all the Cargo.toml changes and the new parity publish now checks those. This can probably be circumvented by having parity publish not bothering to compile the crates if no source changes and no dep changes. For now it shouldn't come up much.

@lexnv
Copy link
Contributor

lexnv commented Nov 25, 2024

Would love to include this to origin/master to unblock semver-checks for:

What are the next steps to merge this? 🙏

@Morganamilo
Copy link
Contributor Author

There were still come issues with parity-publish .10.1. .10.2 is now released so merging as soon as approved.

Comment on lines +9 to +10
homepage.workspace = true
repository.workspace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Morganamilo why just these two bridges modules? Other bridges modules also miss this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the others aren't published? The changes were generated using the crates parity-publish check complained about.

Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here! Thanks again for handling this 🙏

@Morganamilo Morganamilo enabled auto-merge December 3, 2024 11:36
@Morganamilo Morganamilo added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 76a292b Dec 3, 2024
193 of 198 checks passed
@Morganamilo Morganamilo deleted the updpp branch December 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants