Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BEEFY report_fork_voting() #6732

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Dec 2, 2024

Related to #4523

Follow-up for: #5188

@serban300 serban300 added the T15-bridges This PR/Issue is related to bridges. label Dec 2, 2024
@serban300 serban300 self-assigned this Dec 2, 2024
@serban300
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_beefy_mmr
bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=rococo
bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=westend

@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@serban300
Copy link
Contributor Author

bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=rococo

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-0d0bfc95-3ade-42f5-b09c-600f73f7fb78 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087/artifacts/download.

@serban300
Copy link
Contributor Author

bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=westend

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-ee38b68a-0826-4093-81e1-df539846b049 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425/artifacts/download.

@serban300
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_beefy_mmr

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-40577105-9ebe-4394-a46f-27b08ff13b81 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822/artifacts/download.

@serban300 serban300 changed the title [Draft][WIP] Enable BEEFY report_fork_voting() Enable BEEFY report_fork_voting() Dec 3, 2024
@serban300 serban300 marked this pull request as ready for review December 3, 2024 08:43
@serban300 serban300 requested review from bkontur, acatangiu and a team and removed request for acatangiu December 3, 2024 08:43
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@@ -26727,7 +26737,7 @@ dependencies = [
"array-bytes",
"log",
"parity-scale-codec",
"polkadot-ckb-merkle-mountain-range",
"polkadot-ckb-merkle-mountain-range 0.8.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are there two versions of sp-mmr-primitives (and two versions of polkadot-ckb-merkle-mountain-range) used as deps? can you bump whatever is left behind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants