Avoid overwriting existing search methods #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach will always add the following methods to ActiveRecord::Base:
sphinx_search
sphinx_search_for_ids
sphinx_search_count
sphinx_facets
And then, if there aren't methods already existing without the
sphinx_
prefix, they're also added:search
search_for_ids
search_count
facets
This does not remove the possibility that something invoked after Thinking Sphinx will overwrite the
search
method, etc - but at least thesphinx_
-prefixed versions will always be available.This addresses #1264 and is an evolution of #1241.