fix(tslib): lock tslib to 1.13.0 for consumers #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redallen
changed the title
|
PF4 preview: https://patternfly-react-pr-4981.surge.sh |
kmcfaul
approved these changes
Oct 9, 2020
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Our semver of tslib was ^1.11.1, but version 1.14.0 recently released breaking changes that consumers might install if they don't have a lockfile. This PR pins it to the older version until the Typescript team fixes it or we upgrade to tslib 2.
Additional issues: I filed an issue upstream: microsoft/tslib#128