readme

paulmillr · Aug 22, 2024 · 04d070e · 04d070e
1 parent a63b8e5
commit 04d070e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -171,6 +171,8 @@ suffer less from quantum computers. For AES, simply update from AES-128 to AES-2
 
 The library has not been independently audited yet.
 
+There is no protection against side-channel attacks.
+
 If you see anything unusual: investigate and report.
 
 ## Speed

diff --git a/src/ml-dsa.ts b/src/ml-dsa.ts
@@ -164,6 +164,8 @@ function getDilithium(opts: DilithiumOpts): Signer {
     // But they return different results! However, decompose is same.
     // So, either there is a bug in Dilithium ref implementation or in FIPS204.
     // For now, lets use dilithium one, so test vectors can be passed.
+    // See
+    // https://github.com/GiacomoPope/dilithium-py?tab=readme-ov-file#optimising-decomposition-and-making-hints
     return res0;
   };