tiptap 노드 및 마크 전체 리팩토링 #1111
Merged
tiptap 노드 및 마크 전체 리팩토링 #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “:rocket:” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This was referenced Jan 22, 2024
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
배포가 끝나면 아래 주소에서 프리뷰를 확인할 수 있어요.
|
devunt
force-pushed
the
feature/tiptap-styling
branch
4 times, most recently
from
5dc7e5b
to
d40821d
Compare
devunt
force-pushed
the
feature/tiptap-embed
branch
from
80f3a10
to
a578571
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
from
d40821d
to
c8e40da
Compare
Merged
devunt
force-pushed
the
feature/tiptap-styling
branch
5 times, most recently
from
ae7d7c6
to
26638b5
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
4 times, most recently
from
1974b9d
to
6ca5c8e
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
2 times, most recently
from
0b0118d
to
4511335
Compare
mu-hun
previously requested changes
Jan 26, 2024
devunt
force-pushed
the
feature/tiptap-styling
branch
2 times, most recently
from
ce7c8f8
to
24485da
Compare
Merged
devunt
force-pushed
the
feature/tiptap-styling
branch
from
24485da
to
827d616
Compare
This was referenced Jan 28, 2024
Merged
devunt
force-pushed
the
feature/tiptap-styling
branch
from
827d616
to
aaa70dc
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
from
aaa70dc
to
936f577
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
from
936f577
to
e888154
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
from
e888154
to
6aba523
Compare
devunt
force-pushed
the
feature/tiptap-styling
branch
from
6aba523
to
04c6356
Compare
Seohyun-Roh
approved these changes
Jan 30, 2024
robin-maki
approved these changes
Jan 30, 2024
Merge activity
|
팁탭 노드 및 마크 등 관련 코드 전체 에디터 리뉴얼에 맞게 리팩토링함 **주요 변경사항** - `prose.css` 파일을 통해 스타일링하던 부분들을 이제 각 노드/마크/익스텐션에서 바로 스타일을 적용하도록 함 - `letter_spacing`, `line_height`, `text_align` 익스텐션을 deprecate하고 `paragraph`의 attribute로 옮김 (`heading`이 사라져서 `paragraph`에만 적용하면 됨) - `font_family` 익스텐션을 deprecate하고 `font_family` 마크로 재구현함 (이제 인라인으로 적용 가능) - `horizontalRule` 노드를 deprecate하고 `horizontal_rule` 노드로 재구현함 (네이밍 이슈) - `heading` 노드를 deprecate함 (이제 `paragraph` 노드로 처리 가능) - `paragraph`의 `level` attribute를 deprecate함 (이제 폰트 크기를 임의로 설정 가능) - `text_color` 마크를 deprecate하고 `font_color` 마크로 재구현함 (이제 프리셋 컬러 이름이 아닌 hex code를 입력받음) - `font_size` 마크를 신규로 추가함 (이제 폰트 크기를 인라인으로 변경 가능) - 기타 자잘한 코드 수정 및 개선
devunt
force-pushed
the
feature/tiptap-styling
branch
from
04c6356
to
9f95331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
팁탭 노드 및 마크 등 관련 코드 전체 에디터 리뉴얼에 맞게 리팩토링함
주요 변경사항
prose.css파일을 통해 스타일링하던 부분들을 이제 각 노드/마크/익스텐션에서 바로 스타일을 적용하도록 함letter_spacing,line_height,text_align익스텐션을 deprecate하고paragraph의 attribute로 옮김 (heading이 사라져서paragraph에만 적용하면 됨)font_family익스텐션을 deprecate하고font_family마크로 재구현함 (이제 인라인으로 적용 가능)horizontalRule노드를 deprecate하고horizontal_rule노드로 재구현함 (네이밍 이슈)heading노드를 deprecate함 (이제paragraph노드로 처리 가능)paragraph의levelattribute를 deprecate함 (이제 폰트 크기를 임의로 설정 가능)text_color마크를 deprecate하고font_color마크로 재구현함 (이제 프리셋 컬러 이름이 아닌 hex code를 입력받음)font_size마크를 신규로 추가함 (이제 폰트 크기를 인라인으로 변경 가능)