New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused parameter warnings #128

Merged

Tux merged 1 commit into perl5-dbi:master from dveeden:unused_parameter

Aug 27, 2024

Contributor

dveeden commented Aug 26, 2024

Compiling on Fedora 40 with GCC 14.2.1 results in warnings (or errors with -Werror=unused-parameter). This tries to fix these warnings.

DBI.xs: In function ‘dbi_ima_free’:
DBI.xs:250:46: warning: unused parameter ‘mg’ [-Wunused-parameter]
  250 | static int dbi_ima_free(pTHX_ SV* sv, MAGIC* mg)
      |                                       ~~~~~~~^~

DBI.xs: In function ‘sql_type_cast_svpv’:
DBI.xs:1950:65: warning: unused parameter ‘v’ [-Wunused-parameter]
 1950 | sql_type_cast_svpv(pTHX_ SV *sv, int sql_type, U32 flags, void *v)
      |                                                           ~~~~~~^


          Fix unused parameter warnings

8043ecf

Tux reviewed

View reviewed changes

Member

Tux left a comment

I will have to test that on ancient perl before I approve

Thanks so far

Tux approved these changes

View reviewed changes

Tux merged commit bd7bdba into perl5-dbi:master

34 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet