adds in logic for propeller normal direction rotation correction

aerosandbox/geometry/openvsp_io/asb_to_openvsp/propulsor_vspscript_generator.py

@@ -22,14 +22,40 @@ def generate_propulsor(propulsor: Propulsor, include_main=True) -> str:
 
 """
 
+    ### Compute the orientation of the propulsor
+    desired_normal = np.array(propulsor.xyz_normal) / np.linalg.norm(propulsor.xyz_normal)
+
+    if np.allclose(desired_normal, np.array([1, 0, 0]), atol=1e-8):
+        y_rot_deg = 180
+        z_rot_deg = 0
+    else:
+        import aerosandbox as asb
+        opti = asb.Opti()
+        y_rot = opti.variable(init_guess=0, lower_bound=-np.pi, upper_bound=np.pi)
+        z_rot = opti.variable(init_guess=0, lower_bound=-np.pi, upper_bound=np.pi)
+
+        rot = (
+                np.rotation_matrix_3D(angle=y_rot, axis="y") @
+                np.rotation_matrix_3D(angle=z_rot, axis="z")
+        )
+        normal = rot @ np.array([-1, 0, 0])
+
+        opti.maximize(
+            np.dot(normal, desired_normal)
+        )
+        sol = opti.solve(verbose=False)
+        y_rot_deg = np.degrees(sol(y_rot))
+        z_rot_deg = np.degrees(sol(z_rot))
+
     script += f"""\
 //==== Set Overall Propulsor Options and First Section ====//
+SetParmVal( pid, "Y_Rel_Rotation", "XForm", {y_rot_deg:.8g} );
+SetParmVal( pid, "Z_Rel_Rotation", "XForm", {z_rot_deg:.8g} );
 SetParmVal( pid, "X_Rel_Location", "XForm", {propulsor.xyz_c[0]} );
 SetParmVal( pid, "Y_Rel_Location", "XForm", {propulsor.xyz_c[1]} );
 SetParmVal( pid, "Z_Rel_Location", "XForm", {propulsor.xyz_c[2]} );
 SetParmVal( pid, "Diameter", "Design", {2 * propulsor.radius} );
 SetParmVal( pid, "PropMode", "Design", 1.0 ); // 0 = Blades, 1 = Both, 2 = Disk
-
 Update();
 
 """
@@ -50,8 +76,8 @@ def generate_propulsor(propulsor: Propulsor, include_main=True) -> str:
 
     prop = Propulsor(
         name="Prop",
-        xyz_c=np.array([0.5, 0.4, 0.3]),
-        xyz_normal=np.array([1, 0.2, 0.3]),
+        xyz_c=np.array([0, 0, 0]),
+        xyz_normal=np.array([1, 0.1, 0]),
         radius=0.6,
     )
     print(generate_propulsor(prop))