-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite loop in the example on Loops over list of items provided under Section 2.6.2 of TeX-programming-notes.tex #485
base: master
Are you sure you want to change the base?
Conversation
dffaa98
to
e2b52c5
Compare
provided under Section 2.6.2 of TeX-programming-notes.tex
e2b52c5
to
2531e37
Compare
This fix fails if the item iterated over starts with two identical tokens. Example:
|
Thanks! Will make the changes as you suggested. |
@@ -933,10 +933,10 @@ \subsubsection{Loops over list of items} | |||
#2% | |||
\def\next{\looppicker{#1}{#2}}% | |||
\fi | |||
\next | |||
\next% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note I needed to append %
here so make notes
won't get into an infinite loop. Basically a hack to get around what seems to be a flaw of the existing build system.
}% | ||
\listingloop\x in{a,b,c,,d,e}{% | ||
The current item is `\x' | ||
\listingloop\x in{aa, b,c ,,d,e}{% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the test cases to have a wider range of coverage of what otherwise could have gone wrong without being noticed.
Fixes a bug in the example on Loops over list of items provided under Section 2.6.2 of
TeX-programming-notes.tex
.How to locally build
TeX-programming-notes.pdf
from sourcePre-requisite
Build the pdf