use nested eslint configs and remove "getXConfiguration" file pattern…

…s pattern, phetsims/chipper#1483
phetsims · Dec 2, 2024 · 8a191fb · 8a191fb
1 parent 7951bbb
commit 8a191fb
Show file tree

Hide file tree

Showing 5 changed files with 64 additions and 18 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -7,26 +7,10 @@
  * @author Michael Kauzmann (PhET Interactive Simulations)
  */
 
-import { getBrowserConfiguration } from '../perennial-alias/js/eslint/config/browser.eslint.config.mjs';
-import rootEslintConfig from '../perennial-alias/js/eslint/config/root.eslint.config.mjs';
-import getNodeConfiguration from '../perennial-alias/js/eslint/config/util/getNodeConfiguration.mjs';
+import browserEslintConfig from '../perennial-alias/js/eslint/config/browser.eslint.config.mjs';
 
-const nodeJSDirs = [
-  'js/config/**',
-  'js/grunt/**',
-  'js/local/**',
-  'js/node-client/**',
-  'js/server/**'
-];
 export default [
-  ...rootEslintConfig,
-  ...getBrowserConfiguration( {
-    files: [ '**/*' ],
-    ignores: nodeJSDirs
-  } ),
-  ...getNodeConfiguration( {
-    files: nodeJSDirs
-  } ),
+  ...browserEslintConfig,
   {
     languageOptions: {
       globals: {

diff --git a/js/config/eslint.config.mjs b/js/config/eslint.config.mjs
@@ -0,0 +1,14 @@
+// Copyright 2024, University of Colorado Boulder
+
+/**
+ * ESLint configuration for aqua.
+ *
+ * @author Sam Reid (PhET Interactive Simulations)
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+
+import nodeEslintConfig from '../../../perennial-alias/js/eslint/config/node.eslint.config.mjs';
+
+export default [
+  ...nodeEslintConfig
+];
diff --git a/js/grunt/eslint.config.mjs b/js/grunt/eslint.config.mjs
@@ -0,0 +1,20 @@
+// Copyright 2024, University of Colorado Boulder
+
+/**
+ * ESLint configuration for aqua.
+ *
+ * @author Sam Reid (PhET Interactive Simulations)
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+
+import nodeEslintConfig from '../../../perennial-alias/js/eslint/config/node.eslint.config.mjs';
+
+export default [
+  ...nodeEslintConfig,
+  {
+    // TODO: remove once the path works in root config againt, https://github.com/phetsims/chipper/issues/1483/
+    rules: {
+      '@typescript-eslint/no-floating-promises': 'off'
+    }
+  }
+];
diff --git a/js/node-client/eslint.config.mjs b/js/node-client/eslint.config.mjs
@@ -0,0 +1,14 @@
+// Copyright 2024, University of Colorado Boulder
+
+/**
+ * ESLint configuration for aqua.
+ *
+ * @author Sam Reid (PhET Interactive Simulations)
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+
+import nodeEslintConfig from '../../../perennial-alias/js/eslint/config/node.eslint.config.mjs';
+
+export default [
+  ...nodeEslintConfig
+];
diff --git a/js/server/eslint.config.mjs b/js/server/eslint.config.mjs
@@ -0,0 +1,14 @@
+// Copyright 2024, University of Colorado Boulder
+
+/**
+ * ESLint configuration for aqua.
+ *
+ * @author Sam Reid (PhET Interactive Simulations)
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+
+import nodeEslintConfig from '../../../perennial-alias/js/eslint/config/node.eslint.config.mjs';
+
+export default [
+  ...nodeEslintConfig
+];