feat: Separate heart beat interval and timeout #5984
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment (macOS, Chrome) when I switch WiFi, the websocket disconnect event does not occur, it is reconnected by heartbeat. This means that the connection will not be restored for up to one minute with a timeout of the same number of seconds as the interval, which is 30 seconds with the default setting.
However, to resolve this, I feel that heart beat messages at an interval of once every 5 seconds is too much.
At this time, since an online event is generated, I wanted to send a heartbeat triggered by this event to perform disconnect detection with a timeout period shorter than the time of the heartbeat interval.
It is intended to be used as follows. This is expected to reduce the time it takes for the connection to be restored.