Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) : Enhance UnixBuild with proper cleanup and improved test organization #130

Merged
merged 2 commits into from
Nov 26, 2024
Merged

(feat) : Enhance UnixBuild with proper cleanup and improved test organization #130

merged 2 commits into from
Nov 26, 2024

Conversation

tal7aouy
Copy link
Contributor

@tal7aouy tal7aouy commented Nov 23, 2024 •
edited by asgrim
Loading

Fixes #93

This PR enhances the UnixBuild class and its tests with the following improvements:

Changes

  • Added cleanup functionality to UnixBuild to remove build artifacts
  • Refactored UnixBuildTest for better organization and maintainability
  • Added explicit tests for cleanup behavior
  • Improved error handling and verbose output

Technical Details

  • Added cleanup() method to handle make clean and phpize --clean
  • Reorganized tests with proper setup and helper methods
  • Added test cases for verbose output and cleanup scenarios
  • Improved error handling with proper cleanup in failure cases

asgrim
asgrim requested changes Nov 25, 2024
View reviewed changes
src/Building/UnixBuild.php Outdated Show resolved Hide resolved
src/Building/UnixBuild.php Outdated Show resolved Hide resolved
test/integration/Building/UnixBuildTest.php Outdated Show resolved Hide resolved
test/integration/Building/UnixBuildTest.php Outdated Show resolved Hide resolved
@asgrim asgrim self-assigned this Nov 25, 2024
@asgrim asgrim added the enhancement New feature or request label Nov 25, 2024
@asgrim asgrim mentioned this pull request Nov 26, 2024
Closed
@asgrim asgrim added the maintainer feedback needed Needs details or feedback to be added by maintainers label Nov 26, 2024
@asgrim asgrim removed the maintainer feedback needed Needs details or feedback to be added by maintainers label Nov 26, 2024
@asgrim asgrim force-pushed the feature/enhance-unix-build-cleanup branch from 8e7e880 to eaabc96 Compare November 26, 2024 10:42
@asgrim asgrim added this to the 0.3.0 milestone Nov 26, 2024
@asgrim asgrim merged commit 3abe8f5 into php:main Nov 26, 2024
19 checks passed
@asgrim
Copy link
Collaborator

asgrim commented Nov 26, 2024

Thank you @tal7aouy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgrim asgrim asgrim approved these changes

Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Changing configure flags for pie build does not result in a full rebuild
2 participants
@tal7aouy @asgrim