Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Get the number of subscribers of list and added tests #116

Merged
merged 7 commits into from
May 31, 2019
Merged

[FEATURE] Get the number of subscribers of list and added tests #116

merged 7 commits into from
May 31, 2019

Conversation

xh3n1
Copy link
Collaborator

@xh3n1 xh3n1 commented Jan 27, 2019

Fix #115

oliverklee
oliverklee suggested changes Jan 30, 2019
View reviewed changes
src/Controller/ListController.php Show resolved Hide resolved
tests/Integration/Controller/ListControllerTest.php Outdated Show resolved Hide resolved
tests/Integration/Controller/ListControllerTest.php Outdated Show resolved Hide resolved
@xh3n1 xh3n1 force-pushed the subscribers-number branch from 8fb00c7 to 79781fa Compare February 14, 2019 11:43
@xh3n1 xh3n1 force-pushed the subscribers-number branch from 79781fa to 63de167 Compare February 14, 2019 14:42
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Feb 14, 2019

@oliverklee Thank you for the feedback. I think that I have made the requested changes and also added a test for a list without subscribers.

oliverklee
oliverklee suggested changes Mar 1, 2019
View reviewed changes
src/Controller/ListController.php Outdated Show resolved Hide resolved
src/Controller/ListController.php Show resolved Hide resolved
tests/Integration/Controller/AbstractControllerTest.php Outdated Show resolved Hide resolved
tests/Integration/Controller/ListControllerTest.php Outdated Show resolved Hide resolved
tests/Integration/Controller/ListControllerTest.php Outdated Show resolved Hide resolved
@oliverklee
Copy link
Contributor

Hi @xh3n1, could you please fix the build failures? Then I'll take a look at the updated PR. Thanks!

@xh3n1
Copy link
Collaborator Author

xh3n1 commented Mar 20, 2019

@oliverklee yes, thanks!

@oliverklee
Copy link
Contributor

@xh3n1 Do you run the tests locally before you push to GitHub?

@xh3n1 xh3n1 force-pushed the subscribers-number branch from e61c0f4 to b5985f6 Compare April 3, 2019 15:48
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Apr 3, 2019

@oliverklee couldn't run them before because of my environment and it was easier this way.
Now it's ready for review. Thanks.

@xh3n1 xh3n1 changed the title Get the number of subscribers of list and added tests [FEATURE] Get the number of subscribers of list and added tests Apr 3, 2019
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Apr 8, 2019

@oliverklee any further changes I should do before this is ready to go?

@oliverklee
Copy link
Contributor

couldn't run them before because of my environment and it was easier this way.

You really need to have a local setup where you can run the unit tests, functional tests and style checks. If you need TravisCI to run the tests for you, the feedback loop is far too long for you to work productively and have flow while developing.

@oliverklee
Copy link
Contributor

@xh3n1 Have you seen this comment?

Will this actually retrieve all subscribers? Or will this only get the number of subscribers? For performance reasons, I'd prefer the latter.

oliverklee
oliverklee suggested changes Apr 9, 2019
View reviewed changes
src/Controller/ListController.php Outdated Show resolved Hide resolved
tests/Integration/Controller/ListControllerTest.php Outdated Show resolved Hide resolved
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Apr 9, 2019 •
edited
Loading

@oliverklee It gets only the number of subscribers, and I fixed my local setup to run my tests now.

@xh3n1 xh3n1 mentioned this pull request May 31, 2019
Merged
oliverklee
oliverklee approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@oliverklee oliverklee added this to the 4.0.0 phase 3 milestone May 31, 2019
@oliverklee oliverklee merged commit cb7833a into master May 31, 2019
@oliverklee oliverklee deleted the subscribers-number branch May 31, 2019 15:18
@oliverklee
Copy link
Contributor

Oh, it looks like this has broken the build. @xh3n1 Would you be willing to look into this?

@xh3n1
Copy link
Collaborator Author

xh3n1 commented May 31, 2019

@oliverklee yes, I know why. Will create a PR later today.

xh3n1 added a commit that referenced this pull request Jun 4, 2019
@xh3n1
[FEATURE] Get the number of subscribers of list and added tests (#116)
30fde0d 
Closes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtuke samtuke samtuke left review comments

@oliverklee oliverklee oliverklee approved these changes

Assignees

@xh3n1 xh3n1

Labels
enhancement
Projects
None yet
Milestone
4.0.0 phase 3
Development

Successfully merging this pull request may close these issues.

parse the number of subscribers
3 participants
@xh3n1 @oliverklee @samtuke