Fix #912: Ignore deleted files in file_size task

[jmdelehaye]

Q	A
Branch	master for features and deprecations
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Documented?	no
Fixed tickets	#912

This PR :

• adds a FilesCollection->ignoreDeleted() method
• uses this method in FileSize->run() to fix File check always fail after a file is deleted from the repository #912

NB: This dev was made on v1.5.1, due to my local PHP version.

[veewee]

Hello,

Thanks for the PR!
I am a bit confused though:

grumphp/src/Locator/ChangedFiles.php

Lines 56 to 70 in d855145

	private function parseFilesFromDiff(Diff $diff): FilesCollection
	{
	$files = [];
	/** @var File $file */
	foreach ($diff->getFiles() as $file) {
	$fileObject = $this->makeFileRelativeToProjectDir($file);
	if ($file->isDeletion() || !$this->filesystem->exists($fileObject->getPathname())) {
	continue;
	}
	$files[] = $fileObject;
	}
	return new FilesCollection($files);
	}

The files should never contain any deleted files to begin with.
Can you tell me more on how I can reproduce the issue?

[veewee]

We notices this PR became inactive. If you wish to continue, feel free to pick it up again.
If not, we will be closing this PR soon. Thanks for your understanding.