Add phyloref type to phyloreferences #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a phyloreference type (
phylorefType
) to phyloreferences as defined in #6. The value of phylorefType must be one of the following classes from the Phyloref ontology:phyloref:PhyloreferenceUsingMinimumClade
for minimum-clade phylorefs.phyloref:PhyloreferenceUsingMaximumClade
for maximum-clade phylorefs.phyloref:PhyloreferenceUsingApomorphy
for apomorphy-based phylorefs.Separately, we calculate the phyloreference type while we are generating the logical expression (based on the internal and external specifiers), and make the phyloreference a subclass of that class. If the provided phylorefType differs from the computed phyloref type, we will throw an error and refuse to create this phyloreference.
Closes #6.