Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phyloref type to phyloreferences #61

Merged
merged 4 commits into from
Feb 12, 2021
Merged

Add phyloref type to phyloreferences #61

merged 4 commits into from
Feb 12, 2021

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Jan 26, 2021

This PR adds a phyloreference type (phylorefType) to phyloreferences as defined in #6. The value of phylorefType must be one of the following classes from the Phyloref ontology:

  • phyloref:PhyloreferenceUsingMinimumClade for minimum-clade phylorefs.
  • phyloref:PhyloreferenceUsingMaximumClade for maximum-clade phylorefs.
  • phyloref:PhyloreferenceUsingApomorphy for apomorphy-based phylorefs.

Separately, we calculate the phyloreference type while we are generating the logical expression (based on the internal and external specifiers), and make the phyloreference a subclass of that class. If the provided phylorefType differs from the computed phyloref type, we will throw an error and refuse to create this phyloreference.

Closes #6.

@gaurav gaurav marked this pull request as ready for review February 9, 2021 06:35
@gaurav gaurav requested a review from hlapp February 9, 2021 06:35
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you know that the phyloref:Phyloreference subclass relationship is implied by the more specific types, and so enumerating them in OWL is redundant (and thus counter to good practice). I'm not sure whether you're accounting for this anyway in the conversion to OWL. I do, however, see the redundancy in the .nq files, and even RDF reasoners can do subclass reasoning, so I'm not sure.

@gaurav
Copy link
Member Author

gaurav commented Feb 12, 2021

I assume you know that the phyloref:Phyloreference subclass relationship is implied by the more specific types, and so enumerating them in OWL is redundant (and thus counter to good practice). I'm not sure whether you're accounting for this anyway in the conversion to OWL. I do, however, see the redundancy in the .nq files, and even RDF reasoners can do subclass reasoning, so I'm not sure.

Exactly right. I tried removing this direct subclass relationship, but that caused a problem in JPhyloRef (phyloref/jphyloref#74). I'm not sure what the problem is there, but I suspect it's something to do with the way that we load ontologies. Once I fix that, I'll remove the direct subclass relationship here (#74). I don't think this is very urgent, so I'll work on it after we finish the Phyx.js manuscript.

@gaurav gaurav requested a review from hlapp February 12, 2021 05:06
@gaurav gaurav merged commit 9817433 into master Feb 12, 2021
@gaurav gaurav deleted the add-phyloref-type branch February 12, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include clade type in phyloreference definition
2 participants