Skip to content

Commit

Permalink
Merge pull request #218 from dirkrombauts/master
Browse files Browse the repository at this point in the history
Make PowerShell version trace relative paths from the current directory
  • Loading branch information
dirkrombauts committed Sep 24, 2015
2 parents eaafc7a + ac0eac6 commit 2ec3ae0
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 11 deletions.
12 changes: 9 additions & 3 deletions ReleaseNotes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Pickles Release Notes

## v1.2.2 - 2015-09-24

### Bugs Fixed

- The PowerShell version now correctly traces relative paths from the current directory ([#216](https://github.com/picklesdoc/pickles/issues/216))

## v1.2.1 - 2015-08-14

### Bugs Fixed
Expand Down Expand Up @@ -27,7 +33,7 @@
### Bugs Fixed

- Abbreviations displayed incorrectly with spaces between letters ([#192](https://github.com/picklesdoc/pickles/issues/192))

## v1.0.1 - 2015-03-31

### Bugs Fixed
Expand Down Expand Up @@ -55,7 +61,7 @@

- The command line and powershell runners now return an error code of 0 when everything went fine, and 1 if there was an error.
- The HTML and DHTML output versions no longer horizontally spread tables.
- The GUI version has an icon
- The GUI version has an icon

## v0.19.0 - 2014-11-25

Expand Down Expand Up @@ -216,7 +222,7 @@ Some things went wrong during the publication of versions 0.17.0 and 0.17.1. The

## Older Releases without Release Notes

- v0.9 - 2013-07-23
- v0.9 - 2013-07-23
- v0.8 - 2012-12-17
- v0.7 - 2012-08-07
- v0.6 was skipped
Expand Down
2 changes: 1 addition & 1 deletion build.bat
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@echo off
set "picklesVersion=1.2.1"
set "picklesVersion=1.2.2"
set "fakeVersion=3.36.0"

cls
Expand Down
26 changes: 22 additions & 4 deletions src/Pickles/Pickles.PowerShell/Pickle_Features.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ protected override void ProcessRecord()

var configuration = container.Resolve<Configuration>();

this.ParseParameters(configuration, container.Resolve<IFileSystem>());
this.ParseParameters(configuration, container.Resolve<IFileSystem>(), this.SessionState.Path.CurrentFileSystemLocation);

WriteObject(string.Format("Pickles v.{0}{1}", Assembly.GetExecutingAssembly().GetName().Version,
Environment.NewLine));
Expand All @@ -77,10 +77,11 @@ protected override void ProcessRecord()
WriteObject(string.Format("Pickles completed successfully"));
}

private void ParseParameters(Configuration configuration, IFileSystem fileSystem)
private void ParseParameters(Configuration configuration, IFileSystem fileSystem, PathInfo currentFileSystemLocation)
{
configuration.FeatureFolder = fileSystem.DirectoryInfo.FromDirectoryName(this.FeatureDirectory);
configuration.OutputFolder = fileSystem.DirectoryInfo.FromDirectoryName(this.OutputDirectory);
configuration.FeatureFolder = this.DetermineFeatureFolder(fileSystem, currentFileSystemLocation, this.FeatureDirectory);
configuration.OutputFolder = this.DetermineFeatureFolder(fileSystem, currentFileSystemLocation, this.OutputDirectory);

if (!string.IsNullOrEmpty(this.TestResultsFormat))
{
configuration.TestResultsFormat =
Expand All @@ -101,6 +102,23 @@ private void ParseParameters(Configuration configuration, IFileSystem fileSystem
configuration.Language = this.Language;
}
}

private DirectoryInfoBase DetermineFeatureFolder(IFileSystem fileSystem, PathInfo currentFileSystemLocation, string directory)
{
DirectoryInfoBase result;

if (fileSystem.Path.IsPathRooted(directory))
{
result = fileSystem.DirectoryInfo.FromDirectoryName(directory);
}
else
{
result = fileSystem.DirectoryInfo.FromDirectoryName(
fileSystem.Path.Combine(currentFileSystemLocation.Path, directory));
}

return result;
}
}
}
#endif
6 changes: 3 additions & 3 deletions src/Pickles/VersionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
[assembly: AssemblyTrademarkAttribute("")]
[assembly: AssemblyCultureAttribute("")]
[assembly: ComVisibleAttribute(false)]
[assembly: AssemblyVersionAttribute("1.2.1")]
[assembly: AssemblyFileVersionAttribute("1.2.1")]
[assembly: AssemblyVersionAttribute("1.2.2")]
[assembly: AssemblyFileVersionAttribute("1.2.2")]
namespace System {
internal static class AssemblyVersionInformation {
internal const string Version = "1.2.1";
internal const string Version = "1.2.2";
}
}

0 comments on commit 2ec3ae0

Please sign in to comment.