Merge branch 'release-2.4.1'

CHANGELOG.md

@@ -12,7 +12,11 @@ This project adheres to [Semantic Versioning](http://semver.org). We consider th
 
 This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).
 
-## [Unreleased]
+## [2.4.1] - 2016-03-01
+
+### Fixed
+
+- Scenario Outline with parenthesis parses correctly and reports the correct result ([#299](https://github.com/picklesdoc/pickles/pull/299)) (by [@ocsurfnut](https://github.com/ocsurfnut))
 
 ## [2.4.0] - 2016-02-26
 
@@ -33,6 +37,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
 - Word document is corrupt if a Feature has no description ([#261](https://github.com/picklesdoc/pickles/issues/261)) (by [@dirkrombauts](https://github.com/dirkrombauts)).
 - The Cucumber JSON test result provider should deal with background steps correctly  ([#293](https://github.com/picklesdoc/pickles/issues/293)) (by [@dirkrombauts](https://github.com/dirkrombauts) based on [an idea by MikeThomas64](https://github.com/picklesdoc/pickles/pull/251)).
 
+
 ## [2.3.0] - 2016-01-27
 
 ### Added

CONTRIBUTING.md

@@ -8,6 +8,20 @@ Pickles is a volunteer effort. We encourage you to pitch in!
 - Create your code
 - Send a pull request.
 
+### To Contribute to the Test Results Providers
+
+If you find a bug in a Test Result Provider and want to contribute towards fixing it, start of by adding a scenario or feature file that shows off the bug to the test harness solution in the [pickles-testresults repository](https://github.com/picklesdoc/pickles-testresults). Add the scenario to the projects of each test result provider: it is quite likely that the same bug will occur across several test result providers. Don't forget the Cucumber and CucumberJS providers: it's easy to overlook them because they are not in the visual studio solution.
+
+Implement the automation layer in .NET, Ruby and JS if you are able. If you create your scenarios so that they use only steps from the other feature files, then you will most likely not need this step.
+
+Use the `CreateTestresults.cmd` script to create test result files and to deploy them to the source code of Pickles. This step depends on you having checked out the `pickles` and `pickles-testresults` repositories in the same parent directory.
+
+Extend the set of unit tests for the unit test providers. Your best bet is to add test scenarios to the [Standard Test Suite](https://github.com/picklesdoc/pickles/blob/develop/src/Pickles/Pickles.TestFrameworks.UnitTests/StandardTestSuite.cs). Now comes the boring part: for each class that derives from `StandardTestSuite`, add methods in that class that call the test scenarios that you added in `StandardTestSuite`.
+
+You will now have several failing tests. You can now go and fix them :-) 
+
+Once you're done, send a pull request.
+
 ## To Contribute Documentation
 
 - Fork the `doc` repository

build.bat

@@ -1,5 +1,5 @@
 @echo off
-set "picklesVersion=2.4.0"
+set "picklesVersion=2.4.1"
 
 cls
 

src/Pickles/Pickles.TestFrameworks.UnitTests/CucumberJson/WhenParsingCucumberJsonFromJSResultsFile.cs

@@ -106,6 +106,12 @@ public WhenParsingCucumberJsonFromJSResultsFile()
             base.ThenCanReadResultsWithBackslashes();
         }
 
+        [Test]
+        public new void ThenCanReadResultsWithParenthesis()
+        {
+            base.ThenCanReadResultsWithParenthesis();
+        }
+
         [Test]
         public new void ThenCanReadResultOfScenarioWithFailingBackground()
         {

src/Pickles/Pickles.TestFrameworks.UnitTests/CucumberJson/WhenParsingCucumberJsonFromRubyResultsFile.cs

@@ -106,6 +106,12 @@ public WhenParsingCucumberJsonFromRubyResultsFile()
             base.ThenCanReadResultsWithBackslashes();
         }
 
+        [Test]
+        public new void ThenCanReadResultsWithParenthesis()
+        {
+            base.ThenCanReadResultsWithParenthesis();
+        }
+
         [Test]
         public new void ThenCanReadResultOfScenarioWithFailingBackground()
         {