merge of main #33
Open
merge of main #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL introduces an object that can be created on the main thread and then moved to a precompilation thread. This is substantially safer than passing the Context to a precompilation thread. It also holds a ResourceProvider so eliminates the need to allocate a new one for each Precompile call. Bug: b/358074434 Bug: b/373849852 Change-Id: I4ba4530655d65224dcd68e1b1a3e2a0d477bd5fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/919738 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
These are temporarily going offline today. Will revert once they're back online. Change-Id: Ieed1095935d26008423ec80927ede1448fa7fc17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921418 Reviewed-by: Kaylee Lubick <[email protected]> Commit-Queue: Eric Boren <[email protected]>
This reverts commit 0b74d5c. Reason for revert: these are back Original change's description: > [infra] Remove P400 jobs from CQ > > These are temporarily going offline today. Will revert once they're > back online. > > Change-Id: Ieed1095935d26008423ec80927ede1448fa7fc17 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921418 > Reviewed-by: Kaylee Lubick <[email protected]> > Commit-Queue: Eric Boren <[email protected]> Change-Id: Ic72dc12b8c9e9237f16a8f225e808c2cf5358be5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921516 Auto-Submit: Eric Boren <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
Compute fGainmapMathColorSpace from the alternate image's ICC profile. Bug: b/306268460 Change-Id: If097cdcbf01dbe7813432a5325d1114a35bbd862 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/916856 Reviewed-by: Christopher Cameron <[email protected]> Commit-Queue: Vignesh Venkat <[email protected]>
CrabbyAvif supports this format. It is used by Android in low RAM situations. Bug: b/377943473 Change-Id: I1e7a3ef5a3e63ec71ccccdf556715c8c69cc40d2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921449 Auto-Submit: Vignesh Venkat <[email protected]> Commit-Queue: Vignesh Venkat <[email protected]> Reviewed-by: Noelle Scobie <[email protected]>
also add n-linear gradient, and illustrator (attempt) gradient effects Change-Id: Ia973fc6eb5be6ce009b3526483b1f57682d1d1b0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/917256 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Max Hudnell <[email protected]>
Client CLs: - https://crrev.com/c/6031190 - flutter/engine#56627 PDFium used to use skcms_sources, but that was updated in https://pdfium-review.googlesource.com/c/pdfium/+/113670 Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 Reviewed-by: Eric Boren <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/59ce475cae66..824ef0f736ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I9aec207a40810e496b1cd543a41605aff17bcf17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921374 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/3fc6432bcc2f..6898ea1d553e 2024-11-19 [email protected] Roll DirectX Shader Compiler from ac36a797d347 to 891392e87e59 (3 revisions) 2024-11-19 [email protected] Vulkan: Support creating pipeline layout with null bind group layout 2024-11-19 [email protected] [dawn][frontend] Allow creating pipeline layout with null bind group layout 2024-11-18 [email protected] webgpu.h: Update sentinel values for VertexBufferStepMode 2024-11-18 [email protected] [spirv-reader] Support strided f16 matrices 2024-11-18 [email protected] Roll SwiftShader from 4d3a7b64279f to 4074d9674b3e (1 revision) 2024-11-18 [email protected] [spirv-reader] Enable F16 support 2024-11-18 [email protected] Roll vulkan-deps from c93d7c04d2f7 to d79e72d38953 (14 revisions) 2024-11-18 [email protected] Roll ANGLE from 0dc407dc7a85 to 04222c1b36e2 (14 revisions) 2024-11-18 [email protected] Fix an expectation in tint end2end test 2024-11-18 [email protected] Remove stale expectation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Test: Test: dawn_end2end_tests Test: Test: tint_end2end_tests Change-Id: I51c970446d7e007ee00416bb82aafee653cf9161 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921918 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
This CL fixes Bazel build of `experimental/rust_png` directory and captures the currently working build instructions in the `README.md` file. Before this CL the Bazel build would have failed with: ``` experimental/rust_png/impl/SkPngRustCodec.cpp:25:10: error: use of private header from outside its module: 'src/core/SkRasterPipeline.h' [-Wprivate-header] experimental/rust_png/impl/SkPngRustCodec.cpp:26:10: error: use of private header from outside its module: 'src/core/SkRasterPipelineOpList.h' [-Wprivate-header] ``` Bug: chromium:356875275 Change-Id: Ifb51d43308a6ed2b9d8e21a2e01909846bc99ff8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921636 Reviewed-by: Kaylee Lubick <[email protected]> Auto-Submit: Łukasz Anforowicz <[email protected]> Commit-Queue: Łukasz Anforowicz <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/523dc313e7a2..b51256461a37 2024-11-18 [email protected] Hide the outline that appears around the subscription selection toggle when it has focus 2024-11-18 [email protected] Support local spanner-emulator based deployment for coverage service 2024-11-18 [email protected] [autoroll] Provide full support for multiple version files 2024-11-18 [email protected] Roll Skia Infra CIPD packages from 8b12c3aa2ef9 to 523dc313e7a2 (9 revisions) 2024-11-18 [email protected] Roll Depot Tools from c22f4dc74fed to b5eb54d5c1ae (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: Ie0d4c80e10017d4baf1d099eaf2fed93e82ea46a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921898 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3a7b64279f..4074d9674b3e 2024-11-18 [email protected] Regres: Update test lists @ 4d3a7b64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: [email protected] Change-Id: I543050940d0a7d79cf61de510a756f98c40e25ed Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921375 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
This reverts commit 8d652f1. Reason for revert: A couple of Chrome builds still seem to be depending on skia_sksl_default_module_sources Original change's description: > Remove TODOs in GNI exporter tool > > Client CLs: > - https://crrev.com/c/6031190 > - flutter/engine#56627 > > PDFium used to use skcms_sources, but that was updated in > https://pdfium-review.googlesource.com/c/pdfium/+/113670 > > Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 > Reviewed-by: Eric Boren <[email protected]> Change-Id: Ic03324f9b1b071d834c4cfccaabe1fb6b25d796b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922196 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Robert Phillips <[email protected]> Commit-Queue: Robert Phillips <[email protected]> Commit-Queue: Rubber Stamper <[email protected]>
This reverts commit 492e834. Reason for revert: This is blocking the G3 roll bc of the MIT license. Original change's description: > add triangulated gradient effect > > also add n-linear gradient, and illustrator (attempt) gradient effects > > Change-Id: Ia973fc6eb5be6ce009b3526483b1f57682d1d1b0 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/917256 > Reviewed-by: Florin Malita <[email protected]> > Commit-Queue: Max Hudnell <[email protected]> Change-Id: Idf025c6275384df2197221cd9b5428451e59ba18 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922216 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Robert Phillips <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/15492c9bc44d..987cc0de1d4c 2024-11-18 [email protected] Vulkan: Add release utility for BufferViewHelper 2024-11-18 [email protected] CL: Pass in memory properties from cl entry point 2024-11-18 [email protected] CL: Add some event/memory helper functions 2024-11-18 [email protected] Fix validation for 3D depth/stencil textures 2024-11-18 [email protected] Manual roll VK-GL-CTS from f674555ab03e to b27686793f88 (29 revisions) 2024-11-18 [email protected] Tests: Add Block Blast trace 2024-11-18 [email protected] Add a corner case for framebuffer fetch 2024-11-18 [email protected] Add stubs for GL_EXT_texture_storage_compression 2024-11-18 [email protected] Possibly fix FixedQueue.ConcurrentPushPop flakiness 2024-11-18 [email protected] Skip real_racing3 trace on Linux NVIDIA 2024-11-18 [email protected] tools: add buganizer to DIR_METADATA 2024-11-18 [email protected] Roll vulkan-deps from c93d7c04d2f7 to 59ce475cae66 (12 revisions) 2024-11-18 [email protected] Roll Chromium from b3ded8346a3f to 45f7f2245fc1 (752 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: [email protected] Test: Test: angle_trace_tests --gtest_filter="*block_blast*" Change-Id: I53a97e01a0c10cbdae7822853901fa1030aa8dba Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921917 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Noticed this while poking around the CPU backend. Change-Id: Ie253f4999030399067a37861d89ceac6278d0d65 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921676 Commit-Queue: Michael Ludwig <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Michael Ludwig <[email protected]>
This isn't really necessary since we don't care about code size in viewer, but it makes things more consistent with our shader code in core Skia. Change-Id: Ia1f4db1738a71ba3ff4c149d38818b228fd1fe66 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922276 Auto-Submit: Kaylee Lubick <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Commit-Queue: Max Hudnell <[email protected]> Reviewed-by: Max Hudnell <[email protected]>
This is implemented on top of GL timer queries. The client requests the time info on the GrFlushInfo and then receives the time spent on the GPU in a struct passed to the callback. Bug: b/374112296 Change-Id: Id724e68511999d9eb6a8e62497dbb60f784c1bd7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/913377 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Brian Salomon <[email protected]> Reviewed-by: Greg Daniel <[email protected]>
This code was originally added in https://skia-review.googlesource.com/c/skia/+/919696. Fragment processors always return half4 so we're doing conversions for no purpose. Bug: b/379667903 Change-Id: I35e58c4c961a362e116906a0f80a9d7332473760 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921596 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
When using half precision for the thresholds, we can end up in the wrong stop and will calculate values out of bounds from the scale and bias calculation that lead to visible artifacts. Changing to full precision removes those artifacts. Bug: b/379667903 Change-Id: Ib18a498dfdf63a202d599494d31044a6da611c3e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922197 Reviewed-by: James Godfrey-Kittle <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
Change-Id: I02fd5972f545f0b6822d02a75acff8ce865099d5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/915316 Reviewed-by: Ben Wagner <[email protected]> Commit-Queue: Julia Lavrova <[email protected]>
The decoded image buffers contain pointers to Android's MediaCodec buffers which are read-only. So we cannot scale in place. Make a copy of the image if we have to perform scaling. Bug: b/377943473 Change-Id: I64852dca6d257bb2782ed2212f5bc01b8904bdca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921896 Reviewed-by: Noelle Scobie <[email protected]> Auto-Submit: Vignesh Venkat <[email protected]> Commit-Queue: Vignesh Venkat <[email protected]>
Request the correct output color format from android mediacodec based on dstInfo.colorType(). Bug: b/377943473 Change-Id: I5eec41c6e201663beed1e15b89c8b57be613864f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921897 Auto-Submit: Vignesh Venkat <[email protected]> Reviewed-by: Noelle Scobie <[email protected]> Commit-Queue: Vignesh Venkat <[email protected]>
In a separate CL, where I was deleting recorders in threads, I was hitting the singleOwner assert in deregisterRecorder. Bug: b/358074434 Change-Id: Ie1fdb66ad0f767b5ba0e7f22e085730b4eb047f5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922256 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
Additional Client CLs: - https://pdfium-review.googlesource.com/c/pdfium/+/126290 - https://crrev.com/i/7837550 This is a reland of commit 8d652f1 Original change's description: > Remove TODOs in GNI exporter tool > > Client CLs: > - https://crrev.com/c/6031190 > - flutter/engine#56627 > > PDFium used to use skcms_sources, but that was updated in > https://pdfium-review.googlesource.com/c/pdfium/+/113670 > > Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 > Reviewed-by: Eric Boren <[email protected]> Change-Id: I3d866c16f628838661ec400eec41f09b27b5fd35 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921634 Reviewed-by: Eric Boren <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/824ef0f736ed..867065ecbb6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I7b657a0b2fdd6d3c2e47e1ea601053ac249a6d9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922178 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
This came up locally for me when hacking on http://review.skia.org/921997 Not quite sure what changed for me locally, but we should avoid failing like that. Change-Id: I49288abf65945f8d4e7f4614b1c30b1c75a9b9ca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922476 Auto-Submit: Kaylee Lubick <[email protected]> Commit-Queue: Eric Boren <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Reviewed-by: Eric Boren <[email protected]>
Bug: b/374112296 Change-Id: Iab3da25c0c9133a098fe69440b8e9c42fdacdd88 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/913997 Reviewed-by: Greg Daniel <[email protected]> Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Brian Salomon <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/6898ea1d553e..839eadc23139 2024-11-19 [email protected] [ir] Update SingleEntryPoint for Overrides. 2024-11-19 [email protected] Revert "webgpu.h: Remove EnumerateFeatures()" 2024-11-19 [email protected] Compat CTS: remove unexpected passes. 2024-11-19 [email protected] Roll DirectX Shader Compiler from 891392e87e59 to 9b9442cd86c2 (1 revision) 2024-11-19 [email protected] Roll ANGLE from 987cc0de1d4c to e961f7ab353d (6 revisions) 2024-11-19 [email protected] Roll vulkan-deps from d79e72d38953 to 867065ecbb6a (4 revisions) 2024-11-19 [email protected] Compat CTS: triage, remove unexpected passes. 2024-11-19 [email protected] Compat CTS: triage post-CTS roll. 2024-11-19 [email protected] [hlsl] Update DecomposeStorageAccess to conditionalize Convert creation. 2024-11-19 [email protected] [ir] Tighter ValueToLet access restrictions. 2024-11-19 [email protected] Test creating pipeline with a pipeline layout with null bind group layout 2024-11-19 [email protected] webgpu.h: Remove EnumerateFeatures() 2024-11-19 [email protected] Roll ANGLE from 04222c1b36e2 to 987cc0de1d4c (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Test: Test: dawn_unittests Change-Id: I995b89bfc2eef0b72d2053438bda748ec01b66ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922510 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/b51256461a37..7fb17334e756 2024-11-19 [email protected] [perf] fix tooltip position 2024-11-19 [email protected] [perf] convert getLegend and getTitle from DataFrame to DataTable 2024-11-19 [email protected] [perf] google-chart supports axis toggle 2024-11-19 [email protected] [perf] set google chart data to DataTable 2024-11-19 [email protected] Pass in the latest commit id as an argument to the Gold search cache manager 2024-11-19 [email protected] Revert unintentional change of data type in Gold search. 2024-11-19 [email protected] Support running local Gold instance with spanner emulator 2024-11-19 [email protected] [perf] Fix chart tooltip commit link color 2024-11-19 [email protected] Roll Skia Infra CIPD packages from 523dc313e7a2 to b51256461a37 (5 revisions) 2024-11-19 [email protected] Roll Depot Tools from b5eb54d5c1ae to 728e704add46 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I35cc7bf192aec0935c673369a9e896830e43549c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922696 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
Speculative fix for WASM GM build. Change-Id: Id7c8cbebde1c5fb8828332bdc2dd37be51b66e9b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928796 Reviewed-by: Max Hudnell <[email protected]>
* Small name change to avoid confusion before adding push constant support for graphite/Vulkan. Otherwise, can be a bit misleading. Change-Id: Ie4e2d8d318704b6f70a22cc570e02c59b9b4c212 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928800 Auto-Submit: Nicolette Prevost <[email protected]> Commit-Queue: Greg Daniel <[email protected]> Reviewed-by: Greg Daniel <[email protected]>
Apparently these were missed on one or more CLs. I found it by accident when I created a CL that just deleted files. Change-Id: I83bc6b97b9d704a83af072adeb3fa8cbe37d1c9e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928817 Commit-Queue: Nicolette Prevost <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Nicolette Prevost <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]>
As I was poking around the pdf code, I noticed a strange function SkPDFBitmap::GetEncodedInfo(). This felt like something that would go in SkCodecPriv (can't be part of the public API because SkEncodedInfo is private), but that apparently didn't exist. So I made one and moved all the free functions into that. I'm surprised we didn't run into problems earlier, given the fact we have other free functions with similar or same names (e.g. get_int, used in some font code). I also renamed these to align with our more modern naming conventions. Change-Id: Ib90ceee5e92bbebf8c5ff34b3af1973d89b0eb50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928517 Reviewed-by: Daniel Dilan <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Owners-Override: Kaylee Lubick <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/0849df86a686..9513bbe24fc9 2024-12-12 [email protected] [perf] Toggle titles button on multi-graph view full/short graph titles 2024-12-11 [email protected] Fix issue where empty param values cause formatting logic to fail. 2024-12-11 [email protected] [perf] create report link on bug id column in anomalies table 2024-12-11 [email protected] Pop up anomalies table in report-page when user clicks revision-range link. 2024-12-11 [email protected] [perf] sudo docker comands for run-spanner-emulator 2024-12-11 [email protected] Roll Skia Infra CIPD packages from a42d0274444b to 0849df86a686 (7 revisions) 2024-12-11 [email protected] Roll Depot Tools from 25fede45b348 to 06029eb98c92 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: Ie80f723b201b19fb7aea44ef03bd4a500b5f7147 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929096 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/01d91c0571a2..cf71700f44a8 2024-12-12 [email protected] Compat CTS: unskip texture tests on NVidia. 2024-12-12 [email protected] [tint][ir][val] Check access for loads and stores 2024-12-12 [email protected] [msl] Return workgroup storage size 2024-12-12 [email protected] vulkan: suppress validations for subgroup capabilities in VkShaderModuleCreatInfo 2024-12-11 [email protected] Update storage size tests 2024-12-11 [email protected] Roll ANGLE from e45a0420b757 to 9481eb625b35 (4 revisions) 2024-12-11 [email protected] tint_ir_fuzzer: allow building with ASAN enabled 2024-12-11 [email protected] tint_ir_fuzzer: make build fail if missing preconditions 2024-12-11 [email protected] Fix generate_ir_corpus.py to work on Windows 2024-12-11 [email protected] fuzz tool: add -dump parameter 2024-12-11 [email protected] Update tint fuzzer docs 2024-12-11 [email protected] Add Tint contributors as owners for top-level build files 2024-12-11 [email protected] [dawn][test] Update all RequestAdapter usages in tests to new API. 2024-12-11 [email protected] [tint][ir][val] Check only one result for calls to builtins 2024-12-11 [email protected] [HLSL] Return workgroup storage size 2024-12-11 [email protected] [dawn][fuzzer] Fixes leaks caused when device creation fails. 2024-12-11 [email protected] [glsl] Return workgroup storage size 2024-12-11 [email protected] Update MSL Generator to return workgroup information. 2024-12-11 [email protected] Update Dawn to use returned SPIRV workgroup information. 2024-12-11 [email protected] [spirv] Return workgroup storage size 2024-12-11 [email protected] Update HLSL Generator to return workgroup information. 2024-12-11 [email protected] Update GLSL Generator to return workgroup information. 2024-12-11 [email protected] [tint] Polyfill Smoothstep functions for all IR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Change-Id: I84e9b1a2b2e11eeeec4205e33573409e0b7573a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928881 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/769bd5140c26..83e6ead8ab3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I074eb42192464f63b3082f8e3b6b73a7092be1f8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928679 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/9b8cf765f634..e9b33f04020e 2024-12-12 [email protected] Tests: Add Don't Starve Pocket Edition trace 2024-12-12 [email protected] Add option to run deqp tests with native driver on Android 2024-12-12 [email protected] CL/Vulkan: Set depth and height initial values 2024-12-11 [email protected] Manual roll vulkan-deps from 0057c6fd95c9 to 9ee24c2aa734 (16 revisions) 2024-12-11 [email protected] Vulkan: Prevent crash with D/S FF without D/S attachment 2024-12-11 [email protected] Vulkan: Fix DR vs FF vs non-draw RP start 2024-12-11 [email protected] CL/Vulkan: Setup a dispatch loop per commandqueue 2024-12-11 [email protected] Add check for some EGL API attrbute values 2024-12-11 [email protected] Tests: Add Loop Hero trace 2024-12-11 [email protected] Fix primitive restart issue with line loop 2024-12-11 [email protected] Roll Chromium from db1ea12e2e31 to f6784391405b (610 revisions) 2024-12-11 [email protected] Fix glCopyImageSubData() not work with multisample render buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: [email protected] Test: Test: angle_trace_tests --gtest_filter=*dont_starve Test: Test: angle_trace_tests --gtest_filter=*loop_hero Change-Id: Ic534afd0b98536d4d398151380eb069dab0240c8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928880 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
It's just a text file. No-Try: true Change-Id: Ib4f0a5035ef30f5061b438d1e66af3d77ed4a508 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929198 Commit-Queue: Eric Boren <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Eric Boren <[email protected]>
Have SkFontScanner::scanInstance be able to return the variation position of the instance. This allows the user to then merge in any requested variation position. Currently FreeType is getting the incorrect style and variation position for variable instances. This was being hidden by SkTypeface_FreeType::FaceRec::setupAxes ignoring any provided variable position when creating a named instance. This change also removes that. This re-enables the FontConfigInterface_MatchStyleNamedInstance test which was the only one requiring that the named instances and the style be correct. This forces a fix to the Skia side Fontations code. Change-Id: I8f375fc1d39f639b65c17bf6292776a391ff9901 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/926983 Reviewed-by: Julia Lavrova <[email protected]> Commit-Queue: Ben Wagner <[email protected]>
Performance improvement was observed in the following benchmarks, with
around 20 to 30% shorter render time:
colorfilter_linear_to_srgb
colorfilter_srgb_to_linear
colorfilter_highcontrast
Many benchmarks similarly improved using a p3-* backend configuration.
Change-Id: Ie67c576fe85c997f8f0a9a84bd2d45ccae34446b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928440
Commit-Queue: James Godfrey-Kittle <[email protected]>
Reviewed-by: Michael Ludwig <[email protected]>
Bug: b/383302527 Change-Id: I7b75362b992de9d41c8b46be1bd0ae3f5e4bdf99 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928436 Reviewed-by: Nicolette Prevost <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
Bug: b/383303009 Change-Id: I598fb0b07905cc6072d95c3f54e48b8a56a32d8f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928439 Reviewed-by: Nicolette Prevost <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
…inned This caused a problem in a different repo, so we can hopefully catch this problem holistically. Change-Id: I4c8e8de14f8f4b7a6c33f3f1d2a3be51ff139b5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929216 Commit-Queue: Kaylee Lubick <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Eric Boren <[email protected]>
This is the majority of the logging/tracing changes. A follow on CL will add the pipeline-cache purging logging. The new verbose pipeline logs are all structured as: <event-name><P or N> key <unique-key's-hash-value> compilationID <globally-unique-int> Where the 'P' or 'N' encodes whether the Pipeline is from Precompilation or Normal compilation. I'll document this somewhere else but, the <event-name>s form a finite state machine of the Pipeline's lifetime. We have a compilationID (in addition to the pipeline key's hash) bc a given key can be compiled multiple times (due to the caching behavior, threading, and purging). Not accounting for that in the logging can be confusing. The logging is controlled by the SK_PIPELINE_LIFETIME_LOGGING #define in SkUserConfig.h. The plan is to have this defined in Chrome's SkUserConfig.h but we also have it separately added to our local Debug Graphite builds for compilation coverage. Bug: b/358074434 Change-Id: I2e5e8f96e76b2710f8b9fd973001d7ac4b1c67e6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/927979 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
This adds the initial tracing. In a follow up CL I will add additional tracing for the case where a Pipeline is purged w/o ever being used (i.e., the Precompile over-generation case). Bug: b/358074434 Change-Id: I3fa56969623f3f29425c3a318e576c7dc50cbd10 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929237 Commit-Queue: Robert Phillips <[email protected]> Reviewed-by: Michael Ludwig <[email protected]>
This CL uses the RequestAdapterOptions featureLevel option instead of compatibilityMode when requesting GPU adapter from Dawn. Requires https://dawn-review.googlesource.com/c/dawn/+/218534 Bug: 366151404 Change-Id: Ife32082a9209b9884569314dd61ce7e5b2452c25 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928184 Reviewed-by: Michael Ludwig <[email protected]> Reviewed-by: Jim Van Verth <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/83e6ead8ab3b..b56cde80dd49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: Id4acdb5d34118f6425340cf1a7e07d0df98826ff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929377 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
The cache and atlas handling functionality is pretty similar to PathAtlas::DrawAtlasMgr, but it may diverge later and the mask data we're managing has different 'find' and 'add' signatures. Bug: b/379148010 Change-Id: I8644f62e6d2e89d6260e156bb4d5e203035fb671 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929177 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
In this instance a "bad" Pipeline Purge is when the purged Pipeline has never been used (i.e., it was a result of overgeneration). We should never actually see a "BadPurgedN" message since Normally compiled Pipelines get marked as used once they're added to the cache. Bug: b/358074434 Change-Id: I98394445ce7c74391fe5d563c99eef5c34f6fd3b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929356 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
This is essentially a rename of fDisableCachedGlyphUploads to reflect what it actually does. fDisableCachedGlyphUploads will be removed once clients have been changed over to the new name. Also includes a fix to clear the RasterPathAtlas as well, if fRequiredOrderedRecordings isn't true. Change-Id: Ie2877f36925347dbffc9c596e684372a3e7b95aa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929358 Reviewed-by: Robert Phillips <[email protected]> Reviewed-by: Greg Daniel <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
…build Change-Id: I749b3bd50a3ec845f6382fa972a6ac65466fc53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929410 Commit-Queue: Robert Phillips <[email protected]> Reviewed-by: Max Hudnell <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/cf71700f44a8..b8306de17c9a 2024-12-13 [email protected] Roll ANGLE from dc86d618ca3d to c75bd915ec7d (2 revisions) 2024-12-13 [email protected] Compat CTS: more Intel ASTC cube map fails. 2024-12-13 [email protected] [ir] Use inference for nested arrays of builtin structures 2024-12-12 [email protected] Roll Depot Tools from 52d1357a95d7 to 9b4d1e485d37 (63 revisions) 2024-12-12 [email protected] [dawn][fuzzer] Make PipelineLayoutStorageAttachment non-extensible 2024-12-12 [email protected] [spirv][fuzz] Check for embedded null characters in remapped entry point 2024-12-12 [email protected] Expand error message if validating maxColorAttachments with higher limit 2024-12-12 [email protected] Compat CTS: refine textureSampleGrad failures on Intel. 2024-12-12 [email protected] Support D3D12RelaxMinSubgroupSizeTo8 toggle in new subgroup size API 2024-12-12 [email protected] [dawn][test] Update all RequestDevice usages in tests to new API. 2024-12-12 [email protected] Update Dawn to use returned GLSL workgroup information. 2024-12-12 [email protected] Compat CTS: remove unexpected passes on Intel. 2024-12-12 [email protected] Roll ANGLE from 9481eb625b35 to dc86d618ca3d (9 revisions) 2024-12-12 [email protected] Roll vulkan-deps from 9f0e84ff3f69 to f8050f3a8560 (9 revisions) 2024-12-12 [email protected] [tint][ir][val] Reject lets with void types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Change-Id: I771c9783fc63d6098242c90e9c1e68645e7a5975 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929617 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/9513bbe24fc9..9513e7cc4063 2024-12-13 [email protected] [Triage Workflow] Calculate timestamps for each anomaly and use them to generate graphs. 2024-12-12 [email protected] Prevent bazelisk from falling back to newer Bazel versions when not pinned 2024-12-12 [email protected] [perf] add graph button to anomalies table 2024-12-12 [email protected] Roll Skia Infra CIPD packages from 0849df86a686 to 9513bbe24fc9 (7 revisions) 2024-12-12 [email protected] Roll Depot Tools from 06029eb98c92 to 238650f0b1db (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I539625c43afad86a39db77a381e933d6a0e49c83 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929636 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e54d43d6905..c0fe4d40475b 2024-12-13 [email protected] add missing includes for the build with use_libcxx_modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: [email protected] Change-Id: Id907093486d2e20112b4a38e5ec4c52a57760cec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929597 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/b56cde80dd49..034518ee55a5 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1229f1ef3b82498af600965141cde29a3c928e29..13b59bf1d84054b8ccd29cdc6b1303f69e8f9e77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I21c81db5338210855ba8b149f9e69ec049f9f7d2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929638 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/e9b33f04020e..c75bd915ec7d 2024-12-12 [email protected] Vulkan: Remove asyncCommandQueue 2024-12-12 [email protected] CL/VK: Fix event blocking for enqueueReadImage/enqueueMapImage 2024-12-12 [email protected] Roll vulkan-deps from 9ee24c2aa734 to bd600597bc4b (2 revisions) 2024-12-12 [email protected] Roll Chromium from f6784391405b to 7b13ac11cb7e (547 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: [email protected] Change-Id: I4ffa4459d197d7917a81cdd0b9657f7ebdd6f53b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929619 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
This exposes settings on the Context and Recorder for changing the gpu cache budget. Change-Id: I3b9491ab02d59f5f6a19a68e232ce63d04b31082 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929178 Commit-Queue: Greg Daniel <[email protected]> Reviewed-by: Michael Ludwig <[email protected]> Auto-Submit: Greg Daniel <[email protected]>
Chars are passed by value anyway, so making them const in function definitions has no meaning. In the implementation, the const technically matters in that it prevents us from accidentally overwriting the variable, but seems superfluous to me. Clang Tidy suggested removal from one of these and for consistency, I removed them from the others (e.g. the inlined ones) Change-Id: I9c310e77aa2d7de7f4440e07026b34ce3570cf46 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/929756 Commit-Queue: Kaylee Lubick <[email protected]> Commit-Queue: Michael Ludwig <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]> Reviewed-by: Michael Ludwig <[email protected]>
The reason we do this is GoB has (in theory) better uptime and load capacity than GitHub, so our CI tests are less likely to flake when trying to sync. A git admin (me) had to run the following command http://gpaste/4805453788479488 This also generated http://cl/704264552 automagically, but I needed to manually create http://cl/704746328 to make it publicly visible. Then, after updating DEPS, I ran bazelisk run //bazel/deps_parser bazel run //:go generate ./infra/bots/deps/... to update the two generated files. Change-Id: I63f75d706abfe9ad76f4ffd488c709e17c6205af Bug: b/379882101 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/928097 Reviewed-by: Max Hudnell <[email protected]> Commit-Queue: Kaylee Lubick <[email protected]> Auto-Submit: Kaylee Lubick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.