Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync_diff_inspector: use hex to compare blob data #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sync_diff_inspector: use hex to compare blob data #709

wants to merge 2 commits into from
+58 −27

Conversation

erwadba
Copy link
Contributor

@erwadba erwadba commented Mar 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #710

What is changed and how it works?

Use hex to compare blob data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from glorv and lichunzhu March 7, 2023 06:44
@glorv glorv requested review from 3pointer and removed request for glorv March 7, 2023 07:10
lichunzhu
lichunzhu reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

sync_diff_inspector/utils/utils.go
if column.FieldType.GetType() == mysql.TypeFloat || column.FieldType.GetType() == mysql.TypeDouble {
if data1.IsNull && data2.IsNull {
if data1.IsNull && data2.IsNull {
if str1 == str2 {
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When data1 and data2 are nil, str1 == str2 is always true?

sync_diff_inspector/utils/utils.go
if (str1 == str2) && (data1.IsNull == data2.IsNull) {
continue
case mysql.TypeJSON:
var v1, v2 any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check whether str1 == str2 first?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelmdeng michaelmdeng mentioned this pull request May 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
contribution needs-rebase size/M status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync-diff-inspector fix.sql can not execute when data has blob column type.
3 participants
@erwadba @ti-chi-bot @lichunzhu