sync_diff_inspector: Compare rows even if export-fix-sql is false

[dveeden]

What problem does this PR solve?

Issue Number: close #830

What is changed and how it works?

Check List

Tests

• Manual test (add detailed scripts or steps below)

Side effects

• Possible performance regression: Comparing rows is slower than comparing checksums

Related changes

• Need to be included in the release note

Comparing JSON with export-fix-sql being enabled was failing when it shouldn't

[mjonss]

Is it possible to add a test covering this change?

[dveeden]

Is it possible to add a test covering this change?

I added a test in 6e4d864 but I'm not sure if that runs in CI or not

[wuhuizuo]

/retest

[mjonss]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-28 08:50:42.784437953 +0000 UTC m=+712830.404092469: ☑️ agreed by mjonss.

[dveeden]

/hold

[dveeden]

/unhold

[ti-chi-bot]

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify	7c28c74	link	true	/test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,mjonss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment