-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, runtime_filter: Remove redundant logs whose meaning can be directly displayed by default behavior #57626
Conversation
Hi @elsa0520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57626 +/- ##
================================================
+ Coverage 72.8039% 73.4721% +0.6682%
================================================
Files 1676 1676
Lines 463751 464640 +889
================================================
+ Hits 337629 341381 +3752
+ Misses 105237 102452 -2785
+ Partials 20885 20807 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57625
Problem Summary:
What changed and how does it work?
Runtime Filter generator is log the warning message when it cannot generator a RF for a hash join. But RF could not support Tidb hash join by default
Since this type of log will be printed in TiDB in large quantities, as long as query is TiDB hash joins, I decided to delete this log directly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.