Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlreplay, backend: fix bugs to make traffic replay runnable #671

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #642

Problem Summary:
There are some bugs when I manually test traffic capture and replay.

What is changed and how it works:

  • Fix some bugs to make it runnable
  • Refine logs for troubleshoot

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox September 13, 2024 09:57
@ti-chi-bot ti-chi-bot bot added the size/XL label Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.86885% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7a4a4c2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/manager/manager.go 74.07% 6 Missing and 1 partial ⚠️
pkg/sqlreplay/replay/handshake_handler.go 40.00% 6 Missing ⚠️
pkg/sqlreplay/cmd/cmd.go 64.28% 5 Missing ⚠️
pkg/sqlreplay/replay/replay.go 87.09% 4 Missing ⚠️
pkg/sqlreplay/capture/capture.go 88.88% 2 Missing and 1 partial ⚠️
pkg/proxy/net/packetio.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage        ?   69.78%           
=======================================
  Files           ?       99           
  Lines           ?     9419           
  Branches        ?        0           
=======================================
  Hits            ?     6573           
  Misses          ?     2370           
  Partials        ?      476           
Flag Coverage Δ
unit 69.78% <77.86%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 10:23:28.883694262 +0000 UTC m=+611078.624118201: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 9b61266 into pingcap:main Sep 13, 2024
5 checks passed
@djshow832 djshow832 deleted the bugs branch September 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants