Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Remove CommonLogger Adapter #11824

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Dec 13, 2024

No description provided.

@emeroad emeroad added this to the 3.1.0 milestone Dec 13, 2024
@emeroad emeroad force-pushed the #noissue_remove_stdout branch from 93fabc6 to 8577eda Compare December 13, 2024 10:05
@emeroad emeroad force-pushed the #noissue_remove_stdout branch from 8577eda to beb005b Compare December 13, 2024 10:35
@emeroad emeroad merged commit e492e33 into pinpoint-apm:master Dec 13, 2024
1 check passed
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 30.55556% with 25 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (97a368b) to head (beb005b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...avercorp/pinpoint/bootstrap/util/NetworkUtils.java 0.00% 4 Missing ⚠️
.../config/util/spring/PropertyPlaceholderHelper.java 0.00% 3 Missing and 1 partial ⚠️
...rofiler/logging/Log4j2LoggerBinderInitializer.java 0.00% 3 Missing ⚠️
...ler/context/provider/AgentInformationProvider.java 62.50% 3 Missing ⚠️
.../server/util/ServerTraceMetadataLoaderService.java 0.00% 3 Missing ⚠️
...npoint/bootstrap/config/DefaultProfilerConfig.java 50.00% 2 Missing ⚠️
...p/pinpoint/bootstrap/logging/PluginLogManager.java 0.00% 2 Missing ⚠️
...pinpoint/profiler/logging/Log4j2LoggingSystem.java 0.00% 1 Missing and 1 partial ⚠️
...t/common/config/util/ValueAnnotationProcessor.java 0.00% 1 Missing ⚠️
.../common/server/config/TypeLoaderConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11824   +/-   ##
=========================================
  Coverage     37.06%   37.07%           
+ Complexity    12469    12462    -7     
=========================================
  Files          4126     4124    -2     
  Lines        100645   100575   -70     
  Branches      10498    10490    -8     
=========================================
- Hits          37308    37292   -16     
+ Misses        60330    60273   -57     
- Partials       3007     3010    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant