Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vpa plugin #101

Closed
wants to merge 8 commits into from
Closed

Vpa plugin #101

wants to merge 8 commits into from

Conversation

juliababkina
Copy link
Contributor

Solution for the issue #87

josephburnett
josephburnett suggested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@josephburnett josephburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

However, before I submit, please remove the two binary files included. The Makefile puts binaries into a folder which is ignored by git. If I missed something, please add to the Makefile or .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephburnett josephburnett josephburnett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliababkina @josephburnett