Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php v8.1 compatability #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ochorocho
Copy link

New Pull Request checklist

PR Type

What kind of change does this PR introduce?

  • [FEATURE] - A new feature
  • [BUGFIX] - A bug fix
  • [TASK] - Any task, which is not a new feature or bugfix
  • [TEST] - Adding missing tests
  • [DOC] - Documentation only changes
  • [WIP] - Work in progress tag, should not be present when creating pull requests

Breaking change

Does this PR introduce a breaking change?

  • Yes
  • No

Description

Tested in PHP 8.1 and fixed a undefined array key warnings.

Copy link
Contributor

@MattiasNilsson MattiasNilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ochorocho Thanks for the PR! Is seems to be some minor errors, can you fix these? Then I can merge it.

https://github.com/pixelant/pxa_social_feed/actions/runs/6147698048/job/16685159958?pr=194

@ochorocho
Copy link
Author

@ochorocho Thanks for the PR! Is seems to be some minor errors, can you fix these? Then I can merge it.

https://github.com/pixelant/pxa_social_feed/actions/runs/6147698048/job/16685159958?pr=194

Done

@ochorocho
Copy link
Author

Will have a look later in the day

@DavidBruchmann
Copy link

The error message comes from the used actions/cache@v1 in workflows.
That's quite old and outdated, it uses node.js v12:
https://github.com/actions/cache/blob/f5ce41475b483ad7581884324a6eca9f48f8dcc7/action.yml#L17-L21

@MattiasNilsson
Copy link
Contributor

The error message comes from the used actions/cache@v1 in workflows. That's quite old and outdated, it uses node.js v12: https://github.com/actions/cache/blob/f5ce41475b483ad7581884324a6eca9f48f8dcc7/action.yml#L17-L21

We are open for all contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants