Fix crash on disconnect & deallocation

[psineur]

Hi!

In my project I got crashes in -onData: and timer callbacks in SocketIO.m after I called -disconnect on it & released the socket.

I fixed it fo myself by these patches, looks like the main thing was that -onDisconnect: was never called if you're using -disconnect

Hope it helps.
If you want something be made differently - I would love to update the pull request.

Thanks!

P.S.
Now I see that this may look as part of #106, although I haven't experienced flood and simply fixed the crashes.

[taiyangc]

Does this fix #89 ? Hope these fixes get merged soon! @pkyeck Thanks.

[psineur]

Yep. My crashes were from timer.
Looks like #89 is exactly the same issue

Îòïðàâëåíî ñ iPhone

18.06.2013, â 0:51, Eric Chen [email protected] íàïèñàë(à):

Does this fix #89 ? Hope these fixes get merged soon! @pkyeck Thanks.

—
Reply to this email directly or view it on GitHub.

[psineur]

wow, it's declared in BlocksKit, my bad - didn't check this in standalone project
Looks like it's not needed then

[psineur]

Instead of _handshake.delegate = nil it's better to do [_handshake cancel] then

[masterkain]

I'm afflicted by this as well, +1

possibly will fix also #104 which does contain another solution for this.

[taiyangc]

@pkyeck Could you take a look at this fix when you have time? Thanks.