Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @xmldom/xmldom to v0.9.5 #127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KiwiKilian
Copy link

@KiwiKilian KiwiKilian commented Oct 31, 2024

I've upgraded @xmldom/xmldom to 0.9.5 and added the types to allow both DOM and xmldom Element/Node/Document. Otherwise the parsing result of the new versions wouldn't be accepted. I'm not sure if there would be a smoother path? Looks weird on the Docs like Document | Document 🤔.

Otherwise I only had to switch Array.from() to [...].

@KiwiKilian
Copy link
Author

KiwiKilian commented Oct 31, 2024

Might also get resolved by xmldom/xmldom#724 but using the more narrow types of xmldom might be right.

@tmcw
Copy link
Collaborator

tmcw commented Oct 31, 2024

This is a little problematic: xmldom/xmldom in this PR is still in devDependencies, so it is not guaranteed to be installed when togeojson is installed as a dependency, which will potentially cause an issue when the generated typescript types for this package refer to xmldom/xmldom. So we'd have to include @xmldom/xmldom types, which would bump up this package's dependencies by 156kb.

I think in the medium term, only taking the part of this PR that switches from Array.from to spread syntax would be the best tradeoff, and if xmldom doesn't make a change then people could use as unknown to cast to the xmldom desired types.

@KiwiKilian
Copy link
Author

The array spread is also only to resolve type issues.

Wise consideration regarding dependency size. If we keep only import type (removing one value import for the Node Type enum) and move from devDependencies to dependencies it shouldn't harm browser users and only add to developers node_module size. What do you think about this approach?

I think for xmldom to have stricter types is the right move. So using the types within the lib might help to limit to the available functions. And having to use unknown when xmldom is the recommended parser feels a bit off.

@KiwiKilian
Copy link
Author

I've updated with my proposal. Another possibility would be to add xmldom as an optional peer dependency. This would require TypeScript users to install xmldom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants