Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable override of variant name via board.json #15

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

frankleonrose
Copy link

@frankleonrose frankleonrose commented Oct 1, 2019

Fix for issue #14.

@frankleonrose
Copy link
Author

Replicating on local machine - if I remove my change, errors still occur.

I recommend running CircleCI on a weekly schedule in order to detect errors based on changes in dependencies.

@valeros
Copy link
Member

valeros commented Oct 1, 2019

Thanks a lot for the PR. The code in this repository is quite outdated so I need to update in the first place. As for your suggestion, some of the boards (e.g generic* from ststm32 platform) have default variant field reserved for Arduino framework, so that won't be that easy to use variant with mbed.

@frankleonrose
Copy link
Author

I understand. I'm not surprised to run into ecosystem-level conflicts - hard to see at my level.

Does it make sense to use a different name? build.mbed_variant or build.mbed.variant? Or is there a whole different way this should be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants