Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Tested on Ubuntu 20.04, I don't have access to a Windows machine to check classic curses..
Questions from my side :
clear_deprecated_package
than inclean_up
to wipe.git
folder on windows machines ? I can add that commit when confirmed.install-deps.py
script called from tool manager ? With the current logic, there is no way to skip the initial download, that encompass all packages defined in framework basedwest.yml
which leads to unnecessary disk space occupation & installation times.(Example in Ststm32 platform : https://github.com/platformio/platform-ststm32/blob/develop/platform.py#L124)
My proposal would be to launch
install-deps.py
only fromplatformio-build.py
, this way a potential local west.yml can be detected and install time can be dramatically reduced (from 3GB+ to approx 600MB in our case).Opinion :
platformio-build.py
but in practice it does not change much.