Don't hide a node if its children are still loading #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following video you can see the tiles being removed before its children are loaded. I have exaggerated the issue by introducing an additional timeout in the tile renderer loader:
earthatile-tile-popping-issue.mov
The problem; if a node contained GLB content but its children contained JSON, it would be removed after the JSON got loaded and not after the actual new child mesh is loaded.
I solve this by introducing a dependency, there could possibly be a better way to solve it, but for now this works for me.
Here you can see the fix in action:
earthatile-tile-popping-fix.mov