ESM Preload Fix

[marklundin]

This PR fixes playcanvas/editor#1236 along with https://github.com/playcanvas/editor-ui/pull/460.

This removes the ?hash= appended to ESM paths during preloading. This ensures it matches the cache key used for explicit imports in user code, resulting in the same module.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

[mvaligursky]

do we need to cherry pick to main_v1 as well?

[marklundin]

Yep we do

[Maksims]

By removing hash, this will lead to lack of cache invalidations. This will break what developers usually do.
Currently, everything under files/assets folder can be hard cached, because assets pipeline will ensure hash is generated if file changes. So url with hash is hard cached. This is the case for all assets, including scripts.

By changing this, developers will have do more sophisticated rules on caching, and won't be able to use hard caching for scripts.

This is undesirable. Please do not change such well working rule.

The correct solution to this problem is to figure out how to ensure user imported script urls are pre-processed correctly, so they match.

[marklundin]

Could you clarify? The hash param is not included in the classic scripts preload either, so this better aligns the two

due to comment from Maksims

[Maksims]

Could you clarify? The hash param is not included in the classic scripts preload either, so this better aligns the two

I've just checked, and you are correct, there is no hash. Has this been changed at any point? As there was a rule: every asset within assets/files used hashes, so it could be hard cached (200 local storage). Everything outside of that folder is soft-cached (304).

[marklundin]

Yep, script assets do not seem to have a file hash. See 7fe92ef#diff-59cbf44184755e9db171fb7873b5b92241e4bc05bffd75d001d9e6f738c38700R138-R141

The benefits around having a hash are valid though, but need further investigation

[marklundin]

Just to follow up; this needs to be checked with the editor build/export process