Added a new TypeScript definition setting #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finition files the be prefixed to source files.
willeastcott
reviewed
Aug 5, 2024
| @@ -15,9 +15,23 @@ class CloudStorageProvider { | |||
|
|
|||
| this.context = context; | |||
| this._onDidChangeFile = new vscode.EventEmitter(); | |||
|
|
|||
willeastcott
reviewed
Aug 5, 2024
| const config = vscode.workspace.getConfiguration('playcanvas'); | ||
|
|
||
| if (config.get('usePlaycanvasTypes')){ | ||
| this.playCanvasTypesReference = '///<reference path="' + filePath + '" />;\n'; |
There was a problem hiding this comment.
Suggested change
| this.playCanvasTypesReference = '///<reference path="' + filePath + '" />;\n'; | |
| this.playCanvasTypesReference = `///<reference path="${filePath}" />;\n`; |
willeastcott
reviewed
Aug 5, 2024
| let typeScriptDefinitionFilePaths = config.get('additionalTypeScriptDefinitionFiles'); | ||
| if ( typeScriptDefinitionFilePaths ){ | ||
| for (let index = 0; index < typeScriptDefinitionFilePaths.length; index++) { | ||
| this.additionalTypesReferences += '///<reference path="' + typeScriptDefinitionFilePaths[index] + '" />;\n'; |
There was a problem hiding this comment.
Suggested change
| this.additionalTypesReferences += '///<reference path="' + typeScriptDefinitionFilePaths[index] + '" />;\n'; | |
| this.additionalTypesReferences += `///<reference path="${typeScriptDefinitionFilePaths[index]}" />;\n`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new setting to allow users to specify their own TypeScript definition files that will be prefixed to source files.
This has been extremely useful in my work as we have a large number of PlayCanvas scripts that call each other and I found myself having to continually refer to other files to ensure that I was typing out field and functions names correctly. So, I created a .d.ts file that declares TypeScript classes for the script files that I commonly use.
For example this is how I would declare a script that has a single attribute 'textEntity' that is an entity:
declare class {ScriptName} extends pc.ScriptType {
textEntity: pc.Entity;
}
Now when using Visual Studio Code I can use intellisense to reduce the change of an error when I'm working with that script.