Merge pull request #1194 from plentymarkets/feat/throttle_register_route

add throttle to register route
plentymarkets · Mar 22, 2024 · 3c4535c · 3c4535c
2 parents 6d06dac + b070694
commit 3c4535c
Show file tree

Hide file tree

Showing 4 changed files with 205 additions and 108 deletions.
diff --git a/meta/documents/changelog_de.md b/meta/documents/changelog_de.md
@@ -4,10 +4,14 @@
 
 ### Behoben
 
-- Ein Fehler bei der Prüfung von kanonischen Urls in Kombination mit ausgeschlossenen ShopBooster Parametern, kann zu fehlenden alternate links führen. Dies wurde behoben.
+- Ein Fehler bei der Prüfung von kanonischen URLs in Kombination mit ausgeschlossenen ShopBooster-Parametern, kann zu fehlenden alternate links führen. Dies wurde behoben.
 - Es wurde ein Fehler behoben, der dazu führte, dass der Benutzer auf die Homepage umgeleitet wurde, wenn die Sprache auf der Bestellbestätigungsseite geändert wurde.
 - Die Reihenfolge der Artikel auf der Wunschliste wird jetzt beibehalten.
 
+### Geändert
+
+- Die Route zur Kundenregistrierung `/register` enthält jetzt eine IP-basierte Limitierung im plentysystems Kern.
+
 ## v5.0.61 (2023-10-30) <a href="https://github.com/plentymarkets/plugin-io/compare/5.0.60...5.0.61" target="_blank" rel="noopener"><b>Übersicht aller Änderungen</b></a>
 
 ### Behoben

diff --git a/meta/documents/changelog_en.md b/meta/documents/changelog_en.md
@@ -4,10 +4,14 @@
 
 ### Fixed
 
-- An error when checking canonical urls in combination with excluded ShopBooster parameters can lead to missing alternate links. This was fixed.
+- An error when checking canonical URLs in combination with excluded ShopBooster parameters could lead to missing alternate links. This has been fixed.
 - Solved a bug that manifested by redirecting the user to the homepage when the language was changed on order confirmation page.
 - The wish list now preserves the order of the items on the list.
 
+### Changed
+
+- The customer registration route `/register` now contains an IP-based limitation in the plentysystems core.
+
 ## v5.0.61 (2023-10-30) <a href="https://github.com/plentymarkets/plugin-io/compare/5.0.60...5.0.61" target="_blank" rel="noopener"><b>Overview of all changes</b></a>
 
 ### Fixed

diff --git a/src/Api/Resources/CustomerResource.php b/src/Api/Resources/CustomerResource.php
@@ -1,20 +1,15 @@
-<?php //strict
+<?php
 
 namespace IO\Api\Resources;
 
-use IO\Constants\LogLevel;
-use IO\Helper\ReCaptcha;
-use IO\Services\NotificationService;
+use IO\Api\ApiResponse;
+use IO\Api\ResponseCode;
+use IO\Services\CustomerService;
 use Plenty\Modules\Account\Contact\Models\Contact;
-use Plenty\Modules\Webshop\Contracts\ContactRepositoryContract;
 use Plenty\Modules\Webshop\Events\ValidateVatNumber;
 use Plenty\Plugin\Events\Dispatcher;
-use Plenty\Plugin\Http\Response;
 use Plenty\Plugin\Http\Request;
-use IO\Api\ApiResource;
-use IO\Api\ApiResponse;
-use IO\Api\ResponseCode;
-use IO\Services\CustomerService;
+use Plenty\Plugin\Http\Response;
 
 /**
  * Class CustomerResource
@@ -31,9 +26,9 @@ class CustomerResource extends SessionResource
 
     /**
      * CustomerResource constructor.
-     * @param Request $request
-     * @param ApiResponse $response
-     * @param CustomerService $customerService
+     * @param  Request  $request
+     * @param  ApiResponse  $response
+     * @param  CustomerService  $customerService
      */
     public function __construct(
         Request $request,
@@ -44,15 +39,6 @@ public function __construct(
         $this->customerService = $customerService;
     }
 
-    /**
-     * Get the contact.
-     * @return Response
-     */
-    public function index(): Response
-    {
-        return $this->response->create($this->indexCustomer(), ResponseCode::OK);
-    }
-
     /**
      * Save the contact.
      * @return Response
@@ -66,16 +52,6 @@ public function store(): Response
             return $this->response->create(true, ResponseCode::OK);
         }
 
-        if (!ReCaptcha::verify($this->request->get('recaptcha', null))) {
-            /**
-            * @var NotificationService $notificationService
-            */
-            $notificationService = pluginApp(NotificationService::class);
-            $notificationService->addNotificationCode(LogLevel::ERROR, 13);
-
-            return $this->response->create('', ResponseCode::BAD_REQUEST);
-        }
-
         $contactData = $this->request->get('contact', null);
         $billingAddressData = $this->request->get('billingAddress', []);
         $deliveryAddressData = $this->request->get('deliveryAddress', []);
@@ -90,7 +66,7 @@ public function store(): Response
             return $this->response->create(null, ResponseCode::BAD_REQUEST);
         }
 
-         /** @var Dispatcher $eventDispatcher */
+        /** @var Dispatcher $eventDispatcher */
         $eventDispatcher = pluginApp(Dispatcher::class);
 
         if (count($billingAddressData) === 0) {
@@ -123,4 +99,13 @@ public function store(): Response
 
         return $this->index();
     }
+
+    /**
+     * Get the contact.
+     * @return Response
+     */
+    public function index(): Response
+    {
+        return $this->response->create($this->indexCustomer(), ResponseCode::OK);
+    }
 }