Merge pull request #1204 from plentymarkets/fix/tracking_link

Only add tracking url when package number is set
plentymarkets · Oct 8, 2024 · 7a4cedf · 7a4cedf
2 parents d1a21c8 + fd4afb6
commit 7a4cedf
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/Services/OrderTrackingService.php b/src/Services/OrderTrackingService.php
@@ -98,9 +98,8 @@ public function getTrackingURLs(Order $order, $lang): array
                         foreach ($packageNumbers as $packageNo) {
                             $trackingURLs[] = $this->buildTrackingUrl($order, $trackingURL, $packageNo, $lang);
                         }
-                    } else {
+                    } elseif(count($packageNumbers)) {
                         $packageNumber = implode($delimiter, $packageNumbers);
-
                         $trackingURLs[] = $this->buildTrackingUrl($order, $trackingURL, $packageNumber, $lang);
                     }
                 }
@@ -136,4 +135,4 @@ private function buildTrackingUrl(Order $order, string $trackingURL, string $pac
             $trackingURL
         );
     }
-}
+}