Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy of #1182, make sure that new function uses its own variable #1186

Merged
merged 4 commits into from
Mar 5, 2024
Merged

copy of #1182, make sure that new function uses its own variable #1186

merged 4 commits into from
Mar 5, 2024

Conversation

felixgehrmann
Copy link
Contributor

All changes meet the following requirements

  • Changelog entry was added
  • Changes have been documented
  • Changes have been tested by the author
  • Changes have been tested by the reviewer
  • Changes to routes were replicated in webshop package
  • Plugin can be built

@plentymarkets/plentyshop

Supersedes #1182

stentrop
stentrop previously requested changes Oct 25, 2023
View reviewed changes
src/Extensions/Constants/ShopUrls.php Show resolved Hide resolved
@Dominik2809 Dominik2809 dismissed stentrop’s stale review March 1, 2024 08:21

already clarified

@pfrincu-plenty pfrincu-plenty merged commit 6d33746 into stable Mar 5, 2024
3 checks passed
@pfrincu-plenty pfrincu-plenty deleted the feat/multi_tracking_urls branch March 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stentrop stentrop stentrop left review comments

@Dominik2809 Dominik2809 Dominik2809 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixgehrmann @Dominik2809 @stentrop @pfrincu-plenty