Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make pendingMap a WeakMap for better memory management #2396

Merged
merged 10 commits into from
Feb 28, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 13, 2024

It would be super nice, if it's possible.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 3:47pm

Copy link

codesandbox-ci bot commented Feb 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Feb 13, 2024

Size Change: +981 B (+1%)

Total Size: 71.8 kB

Filename Size Change
dist/system/vanilla.development.js 4.36 kB +209 B (+5%) 🔍
dist/system/vanilla.production.js 2.22 kB +126 B (+6%) 🔍
dist/umd/vanilla.development.js 5.22 kB +261 B (+5%) 🔍
dist/umd/vanilla.production.js 2.81 kB +124 B (+5%) 🔍
dist/vanilla.js 5.14 kB +261 B (+5%) 🔍
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 907 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.38 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 757 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.56 kB
dist/system/babel/preset.production.js 1.13 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 722 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla/utils.development.js 4.73 kB
dist/system/vanilla/utils.production.js 2.88 kB
dist/umd/babel/plugin-debug-label.development.js 1.06 kB
dist/umd/babel/plugin-debug-label.production.js 845 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.24 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.43 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla/utils.development.js 5.64 kB
dist/umd/vanilla/utils.production.js 3.47 kB
dist/utils.js 246 B
dist/vanilla/utils.js 5.5 kB

compressed-size-action

Copy link

github-actions bot commented Feb 13, 2024

LiveCodes Preview in LiveCodes

Latest commit: 7401825
Last updated: Feb 23, 2024 3:46pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/A842UN336

See documentations for usage instructions.

@dai-shi dai-shi marked this pull request as ready for review February 24, 2024 03:05
@dai-shi dai-shi added this to the v2.7.0 milestone Feb 24, 2024
@dai-shi dai-shi merged commit f7e2829 into main Feb 28, 2024
34 checks passed
@dai-shi dai-shi deleted the refactor-pending-map branch February 28, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant