Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev store with unstable_derive #2852

Merged
merged 14 commits into from
Dec 23, 2024
Merged

feat: dev store with unstable_derive #2852

merged 14 commits into from
Dec 23, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 11, 2024

Thanks to unstable_derive, we can implement dev store with it.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 3:20am

Copy link

codesandbox-ci bot commented Dec 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Dec 11, 2024

Size Change: +1.11 kB (+1.22%)

Total Size: 92 kB

Filename Size Change
./dist/esm/vanilla.mjs 4.24 kB +250 B (+6.26%) 🔍
./dist/system/vanilla.development.js 4.34 kB +267 B (+6.55%) 🔍
./dist/umd/vanilla.development.js 5.66 kB +300 B (+5.6%) 🔍
./dist/umd/vanilla.production.js 2.85 kB +2 B (+0.07%)
./dist/vanilla.js 5.55 kB +294 B (+5.6%) 🔍
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.4 kB
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.04 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 864 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.production.js 2.14 kB
./dist/system/vanilla/utils.development.js 5.25 kB
./dist/system/vanilla/utils.production.js 3.14 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.57 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla/utils.development.js 6.24 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.1 kB

compressed-size-action

Copy link

github-actions bot commented Dec 11, 2024

LiveCodes Preview in LiveCodes

Latest commit: 897e005
Last updated: Dec 23, 2024 3:19am (UTC)

Playground Link
React demo https://livecodes.io?x=id/9LNKW8YBL

See documentations for usage instructions.

src/vanilla/store.ts Outdated Show resolved Hide resolved
@dai-shi
Copy link
Member Author

dai-shi commented Dec 11, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

@dai-shi
Copy link
Member Author

dai-shi commented Dec 11, 2024

@arjunvegda Let's add jotai-devtools to https://github.com/jotaijs/jotai-ecosystem-ci ! Can you open a PR there?

@dai-shi
Copy link
Member Author

dai-shi commented Dec 11, 2024

Separately, I think createPending should be part of deriveStore.

If necessary, I generally want to make functions as pure as reasonably possible.

(edit: I misunderstood the question.)

@dai-shi
Copy link
Member Author

dai-shi commented Dec 11, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "FAIL",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

@dai-shi
Copy link
Member Author

dai-shi commented Dec 11, 2024

"jotai-devtools": "FAIL",

Yes, it's expected. Cool.

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2852

commit: 897e005

@dai-shi dai-shi changed the title wip: dev store with unstable_derive feat: dev store with unstable_derive Dec 19, 2024
@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "FAIL",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

src/vanilla/store.ts Outdated Show resolved Hide resolved
@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

"jotai-devtools": "FAIL",

Hmm, it's unexpected.

@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

@arjunvegda Can you help here? My expectation is this is compatible behavior-wise, but there might be some cases to break.

@dai-shi dai-shi added this to the v2.11.0 milestone Dec 19, 2024
@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

Hm, I see. Thanks!!

@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

🎉 Thanks @arjunvegda! I'm planning to release this next week.

@dai-shi dai-shi marked this pull request as ready for review December 19, 2024 02:20
src/vanilla/store.ts Outdated Show resolved Hide resolved
@dai-shi
Copy link
Member Author

dai-shi commented Dec 19, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

@dai-shi
Copy link
Member Author

dai-shi commented Dec 23, 2024

/ecosystem-ci run

Copy link

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

@dai-shi dai-shi merged commit 103fb32 into main Dec 23, 2024
43 checks passed
@dai-shi dai-shi deleted the chore/dev-store branch December 23, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants