-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(*): change 'npm i' to 'npm install' #2865
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Preview in LiveCodesLatest commit: 1c8fd7a
See documentations for usage instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this change, but I would like to hear from someone else. How about @dmaskasky and @sandren ?
readme.md
Outdated
@@ -5,7 +5,7 @@ | |||
|
|||
<br> | |||
|
|||
visit [jotai.org](https://jotai.org) or `npm i jotai` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, this was very intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's keep the shorthand here at least. 🙂
I like the change too. I think it's good to be more explicit in most places, but agree with @dai-shi that the shorthand is nice at the top of the readme at least. Thanks! |
Okay, let's do that. |
Co-authored-by: Daishi Kato <[email protected]>
@sukvvon When you have a chance, I'd appreciate if you can look into the flaky test issue. We've been struggling with it with no clues yet. |
@dai-shi If I have time, I will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
npm install
instead of the abbreviationnpm i
is more appropriate, so I made the change.npm install
andnpm i
are used, so I standardizied them.Check List
pnpm run prettier
for formatting code and docs