[Not For Merge] alternate impl for #2827

[dai-shi]

does this work?

ref: #2827

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2024 10:07am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in Stackblitz

More templates

• hacker_news
• hello
• mega-form
• text_length
• todos
• todos_with_atomFamily

npm i https://pkg.pr.new/jotai@2867

commit: 2c26d84

[github-actions]

Size Change: -66 B (-0.07%)

Total Size: 91.1 kB

Filename	Size	Change
./dist/esm/vanilla.mjs	4.04 kB	-31 B (-0.76%)
./dist/system/vanilla.development.js	4.12 kB	-35 B (-0.84%)
./dist/system/vanilla.production.js	2.15 kB	+5 B (+0.23%)
./dist/umd/vanilla.development.js	5.41 kB	+9 B (+0.17%)
./dist/umd/vanilla.production.js	2.85 kB	-20 B (-0.7%)
./dist/vanilla.js	5.31 kB	+6 B (+0.11%)

ℹ️ View Unchanged

Filename	Size
./dist/babel/plugin-debug-label.js	932 B
./dist/babel/plugin-react-refresh.js	1.14 kB
./dist/babel/preset.js	1.41 kB
./dist/esm/babel/plugin-debug-label.mjs	1 kB
./dist/esm/babel/plugin-react-refresh.mjs	1.19 kB
./dist/esm/babel/preset.mjs	1.49 kB
./dist/esm/index.mjs	62 B
./dist/esm/react.mjs	1.4 kB
./dist/esm/react/utils.mjs	746 B
./dist/esm/utils.mjs	67 B
./dist/esm/vanilla/utils.mjs	5.04 kB
./dist/index.js	242 B
./dist/react.js	1.44 kB
./dist/react/utils.js	1.39 kB
./dist/system/babel/plugin-debug-label.development.js	1.1 kB
./dist/system/babel/plugin-debug-label.production.js	775 B
./dist/system/babel/plugin-react-refresh.development.js	1.29 kB
./dist/system/babel/plugin-react-refresh.production.js	928 B
./dist/system/babel/preset.development.js	1.59 kB
./dist/system/babel/preset.production.js	1.14 kB
./dist/system/index.development.js	252 B
./dist/system/index.production.js	183 B
./dist/system/react.development.js	1.56 kB
./dist/system/react.production.js	864 B
./dist/system/react/utils.development.js	860 B
./dist/system/react/utils.production.js	462 B
./dist/system/utils.development.js	257 B
./dist/system/utils.production.js	187 B
./dist/system/vanilla/utils.development.js	5.25 kB
./dist/system/vanilla/utils.production.js	3.14 kB
./dist/umd/babel/plugin-debug-label.development.js	1.08 kB
./dist/umd/babel/plugin-debug-label.production.js	852 B
./dist/umd/babel/plugin-react-refresh.development.js	1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js	1 kB
./dist/umd/babel/preset.development.js	1.54 kB
./dist/umd/babel/preset.production.js	1.22 kB
./dist/umd/index.development.js	383 B
./dist/umd/index.production.js	328 B
./dist/umd/react.development.js	1.57 kB
./dist/umd/react.production.js	936 B
./dist/umd/react/utils.development.js	1.53 kB
./dist/umd/react/utils.production.js	1.01 kB
./dist/umd/utils.development.js	399 B
./dist/umd/utils.production.js	342 B
./dist/umd/vanilla/utils.development.js	6.24 kB
./dist/umd/vanilla/utils.production.js	3.78 kB
./dist/utils.js	247 B
./dist/vanilla/utils.js	6.1 kB

_{compressed-size-action}

[github-actions]

Preview in LiveCodes

Latest commit: 2c26d84
Last updated: Dec 17, 2024 10:07am (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/5NG4U5G2Q

---

See documentations for usage instructions.

[dai-shi]

All tests are passing. We need to create a test to break it.

[dmaskasky]

does this work?

ref: #2827

I don't think it does. There's a couple issues that I see with this implementation:

1. We don't eagerly recompute atoms read with get in a write function.
2. The timing of recompute in flushPending in this implementation is after calling subscribers and onMount.

I don't know if we have test cases for these. Maybe we should add them.

After addressing these two issues, I think this implementation will be similar to #2827.

[dai-shi]

2 was my concern too. it requires a priority queue instead of a set. though, with the react use case, it's not a problem because useReducer dispatch is async. a new test with store api should fail.

1 should be fine unless we want to make different behaviors between mounted atoms and unmounted atoms.

[dmaskasky]

Let me continue to iterate on #2827. I'll have some failing tests later today that we can use as a North star.

unless we want to make different behaviors between mounted atoms and unmounted atoms

I was surprised to see no failing test, tbh. There is definitely a gap in our testing here. The get in write function is always expected to return the latest value. If the atom is dependent on something that changed, we should to recompute that atom in place.

[dai-shi]

Let me continue to iterate on #2827.

That'd be good, and I will cherry-pick commits into this branch.

I'll have some failing tests later today that we can use as a North star.

We are rowing our boats in the ocean from different directions.

[dmaskasky]

Update: I am unable to break this implementation. Nice work.

[dai-shi]

I will try to break 2 and then fix.

[dai-shi]

moved to dmaskasky#1

[dai-shi]

/ecosystem-ci run

[github-actions]

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}