fix(store): robust flush batch #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/D3A5T2E35 |
See documentations for usage instructions.
|
Nice catch. I forgot about that calling a listener can throw. |
dmaskasky
force-pushed
the
fix/robust-flushBatch
branch
from
ffc0008 to
46637d0
Compare
dmaskasky
force-pushed
the
fix/robust-flushBatch
branch
from
46637d0 to
edb0d06
Compare
dmaskasky
force-pushed
the
fix/robust-flushBatch
branch
from
edb0d06 to
fea7fa0
Compare
dmaskasky
force-pushed
the
fix/robust-flushBatch
branch
from
fea7fa0 to
d9178e7
Compare
dmaskasky
force-pushed
the
fix/robust-flushBatch
branch
from
d9178e7 to
ecb4fa9
Compare
dai-shi
reviewed
Dec 18, 2024
Co-authored-by: Daishi Kato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recent refactor #2868 to batching causes a subtle regression in which errors thrown in listeners could cause the remaining listeners for that atom not to run.
This PR flattens listeners to the pending function so errors thown are detected but only rethrown after the remaining listeners have been processed.
Check List
pnpm run prettierfor formatting code and docs