-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): migrate .eslintrc to eslint.config.js #2872
base: main
Are you sure you want to change the base?
chore(eslint): migrate .eslintrc to eslint.config.js #2872
Conversation
… eslint.config.js
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Preview in LiveCodesLatest commit: fc57432
See documentations for usage instructions. |
beforeafter@dai-shi to prevent warning i add |
Please keep the rule and add |
@dai-shi could you explain about |
For unused vars, we have a rule to exclude |
"files": ["tests/**/*.ts", "tests/**/*.tsx"], | ||
"rules": { | ||
"import/extensions": ["error", "never"], | ||
"@typescript-eslint/no-unused-vars": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. We already have it here. Never mind then.
So, it's not you who added it. It was there and you just migrated it. |
@dai-shi i think i forgot, it's my bad 😂 |
@dai-shi right, i already migrated it too |
@dai-shi Is there anything I might have missed? 🤔 |
Just busy. Would you like to join my discord server? https://discord.gg/MrQdmzd |
Sure, I joined! |
Summary
.eslintrc
style toeslint.config.js
ref: pmndrs/zustand#2912
Check List
pnpm run prettier
for formatting code and docs