Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/workflows): improve workflow with removing duplicated configs #2918

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 19, 2024

Summary

  • improve workflow with removing duplicated configs

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:35am

Copy link

codesandbox-ci bot commented Dec 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sukvvon sukvvon changed the title chore(.github/workflows): improve workflow with pnpm dlx and caching chore(.github/workflows/cr.yml): improve workflow with pnpm dlx and caching Dec 19, 2024
Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitzdemo

npm i https://pkg.pr.new/zustand@2918

commit: 9ca8586

@sukvvon sukvvon changed the title chore(.github/workflows/cr.yml): improve workflow with pnpm dlx and caching chore(.github/workflows/cr.yml): improve workflow with caching Dec 19, 2024
- uses: actions/setup-node@v4
with:
node-version: 20
cache: 'pnpm'
- run: pnpm install
cache-dependency-path: '**/pnpm-lock.yaml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default works, so we don't need it. Let's remove it from other *.yml.

- uses: actions/setup-node@v4
with:
node-version: 20
cache: 'pnpm'
- run: pnpm install
cache-dependency-path: '**/pnpm-lock.yaml'
- run: pnpm install --frozen-lockfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

@dai-shi Are you saying that it might not be necessary to specify caching in detail in cr.yml because caching is already being handled in other actions?

@dai-shi
Copy link
Member

dai-shi commented Dec 19, 2024

No, it works without specifying it because it's the default behavior.

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

@dai-shi I was aware that pnpm caching had already been specified and utilized prior to this PR. However, I thought it would look cleaner to ensure consistency with other YML files.

@dai-shi
Copy link
Member

dai-shi commented Dec 19, 2024

yeah, i wasn't aware that for a long time. so, i'm suggesting to make it consistent by removing it in other files.

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

name: Publish Any Commit

on: [push, pull_request]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: pnpm/action-setup@v4
      - uses: actions/setup-node@v4
        with:
          node-version: 20
          cache: 'pnpm'
      - run: pnpm install
      - run: pnpm build
      - run: pnpm dlx pkg-pr-new publish './dist' --compact --template './examples/*'

@dai-shi i understood, you want to simplify like this? by including only what is absolutely necessary.

@dai-shi
Copy link
Member

dai-shi commented Dec 19, 2024

Yes!

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

@dai-shi cool!, i'll do it all in this pr, includes jotai, valtio

@sukvvon sukvvon changed the title chore(.github/workflows/cr.yml): improve workflow with caching chore(.github/workflows/cr.yml): improve workflow with removing duplicated configs Dec 19, 2024
@sukvvon sukvvon changed the title chore(.github/workflows/cr.yml): improve workflow with removing duplicated configs chore(.github/workflows): improve workflow with removing duplicated configs Dec 19, 2024
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Please update the PR description.

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 19, 2024

👏 Please update the PR description.

@dai-shi Done!

@sukvvon sukvvon requested a review from dai-shi December 19, 2024 12:50
@dai-shi
Copy link
Member

dai-shi commented Dec 19, 2024

Thanks for your work for all three repos. I like it.

@dai-shi dai-shi merged commit a7f5128 into pmndrs:main Dec 19, 2024
28 checks passed
@sukvvon sukvvon deleted the chore/add-details-in-cr-action branch December 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants