Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image asset rework #1141

Merged
merged 8 commits into from
Jan 7, 2024
Merged

Image asset rework #1141

merged 8 commits into from
Jan 7, 2024

Conversation

ethteck
Copy link
Member

@ethteck ethteck commented Jan 7, 2024

This PR accomplishes 2 things:

  • Removes all *png.inc.c and *pal.inc.c files from the build, replacing this with simply .incbining the *.png.bin and *pal.bin files.
  • Moves the symbol name for image assets into the c source files, reducing the burden of symbol_addrs.txt needing to store this information across multiple versions. This should make other version support easier as we go.

I plan to do step 2 for vtx and gfx assets soon as well.

@ethteck ethteck merged commit 6da232d into main Jan 7, 2024
2 of 3 checks passed
@ethteck ethteck deleted the asset-rework branch January 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bates64 bates64 bates64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethteck @bates64