Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iQue appendGfx_message #1167

Merged
merged 3 commits into from
Feb 6, 2024
Merged

iQue appendGfx_message #1167

merged 3 commits into from
Feb 6, 2024

Conversation

Alto1772
Copy link
Contributor

@Alto1772 Alto1772 commented Feb 6, 2024

No description provided.

@Alto1772 Alto1772 mentioned this pull request Feb 6, 2024
Merged
6 tasks
@BowserSlug
Copy link
Collaborator

This PR matches -29 functions (+0.48%) on ique.

ethteck
ethteck approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@ethteck ethteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and congrats on this amazing achievement. The note of -29 functions matched is due to glabels being in the asm, which tricks progress.py into thinking several functions have disappeared.

@Alto1772
update progress.py
1a9aa10 
this should 100% by now :)
bates64
bates64 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work

@ethteck ethteck merged commit 6a2ad7e into pmret:main Feb 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bates64 bates64 bates64 approved these changes

@ethteck ethteck ethteck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alto1772 @BowserSlug @ethteck @bates64