Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHIFT_BSS be gone #1173

Merged
merged 13 commits into from
Mar 5, 2024
Merged

SHIFT_BSS be gone #1173

merged 13 commits into from
Mar 5, 2024

Conversation

Alto1772
Copy link
Contributor

No description provided.

@BowserSlug
Copy link
Collaborator

BowserSlug commented Feb 17, 2024

🚀🚀🚀🚀🚀🚀🚀🚀 This PR matches 8 functions (+0.00%) on jp.
🚀 This PR matches 1 function (+0.00%) on ique.

Copy link
Member

@ethteck ethteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing what I said in discord:

I am all for the asm moving into src/ changes

I'll need some more time with it regarding all the BSS stuff

my main concern with this approach is the fact that making things static unfortunately makes them less visible. However, it seems like SHIFT_BSS was defined as just static in some cases anyway...hmm

tools/build/configure.py Show resolved Hide resolved
@bates64 bates64 self-requested a review February 17, 2024 10:43
@Alto1772
Copy link
Contributor Author

Alto1772 commented Feb 17, 2024

my main concern with this approach is the fact that making things static unfortunately makes them less visible. However, it seems like SHIFT_BSS was defined as just static in some cases anyway...hmm

Yeah good suggestion. The reason I did is to just be made as intended by the original developers. The BSS addresses located between the 2 common sections were originally meant to be static so I made it one too...

As a suggestion and my personal understanding, I'll just make the static ones visible by using BSS macro instead. (addendum: except for the libultra & nusys ones)

@ethteck ethteck merged commit 8d5b066 into pmret:main Mar 5, 2024
3 checks passed
@bates64 bates64 removed their request for review March 24, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants