-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHIFT_BSS
be gone
#1173
SHIFT_BSS
be gone
#1173
Conversation
🚀🚀🚀🚀🚀🚀🚀🚀 This PR matches 8 functions (+0.00%) on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echoing what I said in discord:
I am all for the asm moving into src/ changes
I'll need some more time with it regarding all the BSS stuff
my main concern with this approach is the fact that making things static unfortunately makes them less visible. However, it seems like SHIFT_BSS was defined as just static
in some cases anyway...hmm
Yeah good suggestion. The reason I did is to just be made as intended by the original developers. The BSS addresses located between the 2 common sections were originally meant to be static so I made it one too... As a suggestion and my personal understanding, I'll just make the static ones visible by using BSS macro instead. (addendum: except for the libultra & nusys ones) |
No description provided.