Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes code #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bytes code #13

wants to merge 2 commits into from

Conversation

srikanth-tm
Copy link

No description provided.

@kuniteru
Copy link
Member

kuniteru commented Apr 1, 2023

Are #13 and #14 that you pull requested the same changes?

@kuniteru
Copy link
Member

kuniteru commented Apr 1, 2023

I deeply appreciate your contributions.

How does the user fill in the byte array in the message field?
I can't think of an intuitive way for users to enter byte array values.

The message type "Base64 encoded binary" is already provided for the purpose of inputting byte array values.
Wouldn't it serve the purpose to use this and fill in the message field with the value of the base64-encoded byte array?

Perhaps you are expecting only a variable of type byte array to be entered in the message field?
If so, I would like to know of other common Samplers that have a field where only variables can be entered.

If there is such a Sampler, I would like to merge a pull request from you.
If there is no such Sampler, I would like to enter a message as "Base64 encoded binary" with a variable already Base64 encoded in a JSR223 Script such as BeanShell or Groovy, or a byte array variable given to the base64Encode function(https://jmeter-plugins.org/wiki/Functions/#base64Encodesupfont-color-gray-size-1-since-1-2-0-font-sup).

@srikanth-tm
Copy link
Author

srikanth-tm commented Apr 1, 2023 via email

@kuniteru
Copy link
Member

kuniteru commented Apr 1, 2023

Perhaps your message just before was interrupted in the middle?

I now realize that there may be a bug in the "Base64 encoded binary" code.
If this is a glitch, and if it can be fixed so that it works correctly, then your goal may have been achieved with "base64 encoded binary".
In that case, please let me investigate further, since you would end up with two types for the same purpose.

@srikanth-tm
Copy link
Author

srikanth-tm commented Apr 10, 2023 via email

@kuniteru
Copy link
Member

kuniteru commented Apr 12, 2023

Hi,

Thank you for your patience.
I have finally completed the verification of a possible problem with "Base64 encoded binary" and found no problem with it.

You mentioned that you are converting string message to byte, why is that?
The "String" message type provided does not meet your requirements?

Or, instead of adding a "Bytes" message type, why not modify the already provided "String" message type as you have written?

@kuniteru
Copy link
Member

I had written in a previous comment, "Or, instead of adding a "Bytes" message type, why not modify the already provided "String" message type as you have written?", but this was not possible.

@srikanth-tm
Copy link
Author

srikanth-tm commented Apr 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants