Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.15.0 #154

Merged
merged 30 commits into from
Feb 5, 2024
Merged

Release/1.15.0 #154

merged 30 commits into from
Feb 5, 2024

Conversation

skorper
Copy link
Contributor

@skorper skorper commented Feb 1, 2024

[1.15.0]

Added

  • Added support for Harmony subsetting

@skorper skorper requested a review from jimmie February 1, 2024 18:25
try:
pa.create_citation_file(short_name, provider, data_path, token, args.verbose)
except:
logging.debug('Error generating citation', exc_info=True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be logging.error instead?

Copy link

@hkryeung hkryeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in some minor comments but overall code looks good!

@skorper skorper merged commit e8f961d into main Feb 5, 2024
24 checks passed
@skorper skorper deleted the release/1.15.0 branch February 5, 2024 21:51
@skorper skorper restored the release/1.15.0 branch February 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants