Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a json string for field config #6436

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Feb 3, 2022

Description

This PR allows a JSON string to be passed as a field configuration array for Pods Forms.

Related GitHub issue(s)

Fixes #6435

Testing instructions

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See '....'

Screenshots / screencast

Changelog text for these changes

  • Support JSON as field configuration strings for the [pods_form] shortcode.

PR checklist

@JoryHogeveen JoryHogeveen added Type: Enhancement Enhancements to features that already exist, but are not major additions Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done labels Feb 3, 2022
@JoryHogeveen JoryHogeveen added this to the Pods 2.8.11 milestone Feb 3, 2022
@JoryHogeveen JoryHogeveen self-assigned this Feb 3, 2022
sc0ttkclark
sc0ttkclark previously approved these changes Feb 7, 2022
@sc0ttkclark
Copy link
Member

Looks good, let's be sure to set a changelog text entry in this PR description before merging

@JoryHogeveen
Copy link
Member Author

@sc0ttkclark Done!

@sc0ttkclark
Copy link
Member

This looks good but in practice, don't we have to contend with WP shortcodes handling of double quotes etc that JSON would be using?

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8.11, Pods 2.8.12 Feb 21, 2022
@sc0ttkclark sc0ttkclark changed the base branch from main to release/2.8.11 February 23, 2022 04:03
@sc0ttkclark sc0ttkclark dismissed their stale review February 23, 2022 04:03

The base branch was changed.

@JoryHogeveen
Copy link
Member Author

Hi @sc0ttkclark Good point, will need to be tested

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8.12, Pods 2.8.13 Apr 8, 2022
Base automatically changed from release/2.8.11 to main April 8, 2022 05:19
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8.13, Pods 2.8.14, Pods 2.8.15 Apr 8, 2022
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8.17, Pods 2.8.19 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done Type: Enhancement Enhancements to features that already exist, but are not major additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overwriting params in pods_form fields
2 participants