-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date format mapper - redo #7041
base: main
Are you sure you want to change the base?
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes here needed but it's very close. Let's be sure to add coverage for all of the available options/logic in the tests/codeception/wpunit/Pods/MappingTest.php
file.
PR Summary
|
Co-authored-by: Scott Kingsley Clark <[email protected]>
PR Summary
|
PR Summary
|
PR Summary
|
PR Summary
|
PR Summary
|
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we could improve with some assertions on an object field but it's good either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not get why the tests are failing, and definitely not why it returns false. |
Related: #4525
Related: #5675
Description
This is a redo from an earlier PR: #5676
With this PR you can set your own formats when using date fields.
Text from prev PR:
This PR does NOT change the default behavior. It only adds the option to define a format (or select WP default format).
Testing instructions
Screenshots / screencast
Changelog text for these changes
PR checklist